From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mike Dunn <mikedunn@newsguy.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd: cafe_nand: fix an & vs | mistake
Date: Mon, 18 Jun 2012 11:07:55 +0000 [thread overview]
Message-ID: <1340017675.2420.25.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120609160825.GC6488@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Sat, 2012-06-09 at 19:08 +0300, Dan Carpenter wrote:
> The intent here was clearly to set result to true if the 0x40000000 flag
> was set. But instead there was a | vs & typo and we always set result
> to true.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I do not have the hardware to test this. The original code is clearly
> buggy, but what about if 0x40000000 is the wrong flag?
Looks like it is the right flag, I've checked
wiki.laptop.org/images/5/5c/88ALP01_Datasheet_July_2007.pdf
and your patch looks correct.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mike Dunn <mikedunn@newsguy.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd: cafe_nand: fix an & vs | mistake
Date: Mon, 18 Jun 2012 14:07:55 +0300 [thread overview]
Message-ID: <1340017675.2420.25.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120609160825.GC6488@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Sat, 2012-06-09 at 19:08 +0300, Dan Carpenter wrote:
> The intent here was clearly to set result to true if the 0x40000000 flag
> was set. But instead there was a | vs & typo and we always set result
> to true.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I do not have the hardware to test this. The original code is clearly
> buggy, but what about if 0x40000000 is the wrong flag?
Looks like it is the right flag, I've checked
wiki.laptop.org/images/5/5c/88ALP01_Datasheet_July_2007.pdf
and your patch looks correct.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-18 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 19:14 smatch stuff: mtd/cafe_nand: cafe_device_ready() always returns true Dan Carpenter
2012-06-09 9:37 ` Dan Carpenter
2012-06-09 16:08 ` [patch] mtd: cafe_nand: fix an & vs | mistake Dan Carpenter
2012-06-09 16:08 ` Dan Carpenter
2012-06-18 11:07 ` Artem Bityutskiy [this message]
2012-06-18 11:07 ` Artem Bityutskiy
2012-06-18 11:25 ` Artem Bityutskiy
2012-06-18 11:25 ` Artem Bityutskiy
2012-08-17 21:44 ` Daniel Drake
2012-08-17 21:44 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340017675.2420.25.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.