All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, Zhangjin Wu <wuzhangjin@gmail.com>,
	Hua Yan <yanh@lemote.com>, Fuxin Zhang <zhangfx@lemote.com>,
	dri-devel@lists.freedesktop.org, Hongliang Tao <taohl@lemote.com>,
	Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH V2 12/16] drm/radeon: Make radeon card usable for Loongson.
Date: Tue, 19 Jun 2012 09:56:45 +0200	[thread overview]
Message-ID: <1340092605.5442.0.camel@thor.local> (raw)
In-Reply-To: <1340088624-25550-13-git-send-email-chenhc@lemote.com>

On Die, 2012-06-19 at 14:50 +0800, Huacai Chen wrote: 
> 1, Use 32-bit DMA as a workaround (Loongson has a hardware bug that it
>    doesn't support DMA address above 4GB).
> 2, Read vga bios offered by system firmware.
> 3, Handle io prot correctly for MIPS.
> 4, Don't use swiotlb on Loongson machines (when use swiotlb, GPU reset
>    occurs at resume from suspend).

Sounds like this should be split up into smaller patches.


> diff --git a/include/drm/drm_sarea.h b/include/drm/drm_sarea.h
> index ee5389d..1d1a858 100644
> --- a/include/drm/drm_sarea.h
> +++ b/include/drm/drm_sarea.h
> @@ -37,6 +37,8 @@
>  /* SAREA area needs to be at least a page */
>  #if defined(__alpha__)
>  #define SAREA_MAX                       0x2000U
> +#elif defined(__mips__)
> +#define SAREA_MAX                       0x4000U
>  #elif defined(__ia64__)
>  #define SAREA_MAX                       0x10000U	/* 64kB */
>  #else

Also, this change doesn't seem to be accounted for in the commit log.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer

WARNING: multiple messages have this Message-ID (diff)
From: "Michel Dänzer" <michel@daenzer.net>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: linux-mips@linux-mips.org, Zhangjin Wu <wuzhangjin@gmail.com>,
	Hua Yan <yanh@lemote.com>,
	dri-devel@lists.freedesktop.org,
	Ralf Baechle <ralf@linux-mips.org>,
	Fuxin Zhang <zhangfx@lemote.com>, Huacai Chen <chenhc@lemote.com>,
	Hongliang Tao <taohl@lemote.com>
Subject: Re: [PATCH V2 12/16] drm/radeon: Make radeon card usable for Loongson.
Date: Tue, 19 Jun 2012 09:56:45 +0200	[thread overview]
Message-ID: <1340092605.5442.0.camel@thor.local> (raw)
In-Reply-To: <1340088624-25550-13-git-send-email-chenhc@lemote.com>

On Die, 2012-06-19 at 14:50 +0800, Huacai Chen wrote: 
> 1, Use 32-bit DMA as a workaround (Loongson has a hardware bug that it
>    doesn't support DMA address above 4GB).
> 2, Read vga bios offered by system firmware.
> 3, Handle io prot correctly for MIPS.
> 4, Don't use swiotlb on Loongson machines (when use swiotlb, GPU reset
>    occurs at resume from suspend).

Sounds like this should be split up into smaller patches.


> diff --git a/include/drm/drm_sarea.h b/include/drm/drm_sarea.h
> index ee5389d..1d1a858 100644
> --- a/include/drm/drm_sarea.h
> +++ b/include/drm/drm_sarea.h
> @@ -37,6 +37,8 @@
>  /* SAREA area needs to be at least a page */
>  #if defined(__alpha__)
>  #define SAREA_MAX                       0x2000U
> +#elif defined(__mips__)
> +#define SAREA_MAX                       0x4000U
>  #elif defined(__ia64__)
>  #define SAREA_MAX                       0x10000U	/* 64kB */
>  #else

Also, this change doesn't seem to be accounted for in the commit log.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2012-06-19  7:57 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  6:50 [PATCH V2 00/14] MIPS: Add Loongson-3 based machines support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 01/16] MIPS: Loongson: Add basic Loongson-3 definition Huacai Chen
2012-06-19  9:36   ` Florian Fainelli
2012-06-19 10:44     ` Huacai Chen
2012-06-19  6:50 ` [PATCH V2 02/16] MIPS: Loongson: Add basic Loongson-3 CPU support Huacai Chen
2012-06-19  9:47   ` Florian Fainelli
2012-06-19 10:45     ` Huacai Chen
2012-06-19  6:50 ` [PATCH V2 03/16] MIPS: Loongson 3: Add Lemote-3A machtypes definition Huacai Chen
2012-06-19 11:08   ` Sergei Shtylyov
2012-06-19 11:46     ` Huacai Chen
2012-06-19  6:50 ` [PATCH V2 04/16] MIPS: Loongson: Make Loongson-3 to use BCD format for RTC Huacai Chen
2012-06-19  6:50 ` [PATCH V2 05/16] MIPS: Loongson: Add UEFI-like firmware interface support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 06/16] MIPS: Loongson 3: Add HT-linked PCI support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 07/16] MIPS: Loongson 3: Add IRQ init and dispatch support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 08/16] MIPS: Loongson 3: Add serial port support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 09/16] MIPS: Loongson: Add swiotlb to support big memory (>4GB) Huacai Chen
2012-06-19  6:50 ` [PATCH V2 10/16] MIPS: Loongson: Add Loongson-3 Kconfig options Huacai Chen
2012-06-19  6:50 ` [PATCH V2 11/16] ata: Use 32-bit DMA in AHCI for Loongson-3 Huacai Chen
2012-06-19 12:32   ` Jeff Garzik
2012-06-19 12:36     ` Huacai Chen
2012-06-19  6:50 ` [PATCH V2 12/16] drm/radeon: Make radeon card usable for Loongson Huacai Chen
2012-06-19  7:19   ` Lucas Stach
2012-06-19 14:07     ` j.glisse
2012-06-20  6:12     ` Huacai Chen
2012-06-20  6:38       ` Lucas Stach
2012-06-20  6:54         ` Huacai Chen
2012-06-19  7:56   ` Michel Dänzer [this message]
2012-06-19  7:56     ` Michel Dänzer
2012-06-19 10:46     ` Huacai Chen
2012-06-19 10:46       ` Huacai Chen
2012-06-19 13:57   ` j.glisse
2012-06-20  1:26     ` Alex Deucher
2012-06-20  1:26       ` Alex Deucher
2012-06-20  8:28       ` Huacai Chen
2012-06-20 16:16         ` Alex Deucher
2012-06-20 16:16           ` Alex Deucher
2012-06-19  6:50 ` [PATCH V2 13/16] ALSA: HDA: Make hda sound " Huacai Chen
2012-06-19  6:50   ` Huacai Chen
2012-06-19  9:09   ` Clemens Ladisch
2012-06-19  9:09     ` [alsa-devel] " Clemens Ladisch
2012-06-19  9:26   ` Takashi Iwai
2012-06-19 10:47     ` Huacai Chen
2012-06-19 10:47       ` [alsa-devel] " Huacai Chen
2012-06-19  6:50 ` [PATCH V2 14/16] MIPS: Loongson 3: Add Loongson-3 SMP support Huacai Chen
2012-06-19  6:50 ` [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support Huacai Chen
2012-06-19  9:31   ` Yong Zhang
2012-06-19  9:31     ` Yong Zhang
2012-06-19 10:51     ` Huacai Chen
2012-06-20  6:36       ` Yong Zhang
2012-06-20  6:36         ` Yong Zhang
2012-06-20  6:57         ` Huacai Chen
2012-06-19  9:32   ` Yong Zhang
2012-06-19  9:32     ` Yong Zhang
2012-06-19  6:50 ` [PATCH V2 16/16] MIPS: Loongson: Add a Loongson-3 default config file Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340092605.5442.0.camel@thor.local \
    --to=michel@daenzer.net \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=taohl@lemote.com \
    --cc=wuzhangjin@gmail.com \
    --cc=yanh@lemote.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.