From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare
Date: Mon, 25 Jun 2012 06:07:58 +0000 [thread overview]
Message-ID: <1340604478.12683.25.camel@lappyti> (raw)
In-Reply-To: <1340372890-10091-6-git-send-email-rnayak@ti.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
Hi,
On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote:
> In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare()
> and clk_unprepare() for the omapdss clocks.
You used clk_prepare and clk_unprepare instead of clk_prepare_enable and
clk_disable_unprepare. I didn't check the dss driver yet, but my hunch
is that the clocks are normally not enabled/disabled from atomic
context.
What does the prepare/unprepare actually do? Is there any benefit in
delaying preparing, i.e. is there a difference between prepare right
after clk_get, or prepare right before clk_enable? (And similarly for
unprepare)
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: paul@pwsan.com, mturquette@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare
Date: Mon, 25 Jun 2012 09:07:58 +0300 [thread overview]
Message-ID: <1340604478.12683.25.camel@lappyti> (raw)
In-Reply-To: <1340372890-10091-6-git-send-email-rnayak@ti.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
Hi,
On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote:
> In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare()
> and clk_unprepare() for the omapdss clocks.
You used clk_prepare and clk_unprepare instead of clk_prepare_enable and
clk_disable_unprepare. I didn't check the dss driver yet, but my hunch
is that the clocks are normally not enabled/disabled from atomic
context.
What does the prepare/unprepare actually do? Is there any benefit in
delaying preparing, i.e. is there a difference between prepare right
after clk_get, or prepare right before clk_enable? (And similarly for
unprepare)
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare
Date: Mon, 25 Jun 2012 09:07:58 +0300 [thread overview]
Message-ID: <1340604478.12683.25.camel@lappyti> (raw)
In-Reply-To: <1340372890-10091-6-git-send-email-rnayak@ti.com>
Hi,
On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote:
> In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare()
> and clk_unprepare() for the omapdss clocks.
You used clk_prepare and clk_unprepare instead of clk_prepare_enable and
clk_disable_unprepare. I didn't check the dss driver yet, but my hunch
is that the clocks are normally not enabled/disabled from atomic
context.
What does the prepare/unprepare actually do? Is there any benefit in
delaying preparing, i.e. is there a difference between prepare right
after clk_get, or prepare right before clk_enable? (And similarly for
unprepare)
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120625/fb172c0f/attachment.sig>
next prev parent reply other threads:[~2012-06-25 6:07 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 13:47 [PATCH 00/11] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-06-22 13:47 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 01/11] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 17:42 ` Pankaj Jangra
2012-06-22 17:42 ` Pankaj Jangra
2012-06-25 5:36 ` Rajendra Nayak
2012-06-25 5:36 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 02/11] mmc: omap: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 18:23 ` S, Venkatraman
2012-06-22 18:23 ` S, Venkatraman
2012-06-22 18:34 ` Paul Walmsley
2012-06-22 18:34 ` Paul Walmsley
2012-06-25 5:25 ` Rajendra Nayak
2012-06-25 5:25 ` Rajendra Nayak
2012-06-25 6:18 ` Paul Walmsley
2012-06-25 6:18 ` Paul Walmsley
2012-06-25 7:13 ` Rajendra Nayak
2012-06-25 7:13 ` Rajendra Nayak
2012-06-25 5:32 ` Rajendra Nayak
2012-06-25 5:32 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 03/11] hwrng: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 04/11] mfd: omap-usb: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 19:04 ` Paul Walmsley
2012-06-22 19:04 ` Paul Walmsley
2012-06-25 8:55 ` Munegowda, Keshava
2012-06-25 8:55 ` Munegowda, Keshava
2012-06-22 13:48 ` [PATCH 05/11] OMAPDSS: " Rajendra Nayak
2012-06-22 13:51 ` Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-25 6:07 ` Tomi Valkeinen [this message]
2012-06-25 6:07 ` Tomi Valkeinen
2012-06-25 6:07 ` Tomi Valkeinen
2012-06-25 6:59 ` Rajendra Nayak
2012-06-25 7:11 ` Rajendra Nayak
2012-06-25 6:59 ` Rajendra Nayak
2012-06-25 7:58 ` Tomi Valkeinen
2012-06-25 7:58 ` Tomi Valkeinen
2012-06-25 7:58 ` Tomi Valkeinen
2012-06-25 11:48 ` Rajendra Nayak
2012-06-25 11:52 ` Rajendra Nayak
2012-06-25 11:48 ` Rajendra Nayak
2012-06-25 13:14 ` Tomi Valkeinen
2012-06-25 13:14 ` Tomi Valkeinen
2012-06-25 13:14 ` Tomi Valkeinen
2012-06-26 5:00 ` Rajendra Nayak
2012-06-26 5:12 ` Rajendra Nayak
2012-06-26 5:00 ` Rajendra Nayak
2012-06-26 6:55 ` Tomi Valkeinen
2012-06-26 6:55 ` Tomi Valkeinen
2012-06-26 6:55 ` Tomi Valkeinen
2012-06-26 7:36 ` Rajendra Nayak
2012-06-26 7:48 ` Rajendra Nayak
2012-06-26 7:36 ` Rajendra Nayak
2012-06-27 0:47 ` Mike Turquette
2012-06-27 0:47 ` Mike Turquette
2012-06-27 0:47 ` Mike Turquette
2012-06-27 4:19 ` Tomi Valkeinen
2012-06-27 4:19 ` Tomi Valkeinen
2012-06-27 4:19 ` Tomi Valkeinen
2012-06-27 5:19 ` Rajendra Nayak
2012-06-27 5:31 ` Rajendra Nayak
2012-06-27 5:19 ` Rajendra Nayak
2012-06-25 11:22 ` Russell King - ARM Linux
2012-06-25 11:22 ` Russell King - ARM Linux
2012-06-25 11:22 ` Russell King - ARM Linux
2012-06-22 13:48 ` [PATCH 06/11] gpio/omap: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 15:57 ` Pankaj Jangra
2012-06-22 15:57 ` Pankaj Jangra
2012-06-22 19:17 ` Paul Walmsley
2012-06-22 19:17 ` Paul Walmsley
2012-06-25 5:30 ` Rajendra Nayak
2012-06-25 5:30 ` Rajendra Nayak
2012-06-25 6:11 ` DebBarma, Tarun Kanti
2012-06-25 6:11 ` DebBarma, Tarun Kanti
2012-06-25 7:02 ` Rajendra Nayak
2012-06-25 7:02 ` Rajendra Nayak
2012-06-25 10:22 ` DebBarma, Tarun Kanti
2012-06-25 10:22 ` DebBarma, Tarun Kanti
2012-06-22 13:48 ` [PATCH 07/11] w1: omap_hdq: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 18:35 ` Paul Walmsley
2012-06-22 18:35 ` Paul Walmsley
2012-06-25 5:25 ` Rajendra Nayak
2012-06-25 5:25 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 08/11] crypto: omap: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 18:58 ` Paul Walmsley
2012-06-22 18:58 ` Paul Walmsley
2012-06-25 5:29 ` Rajendra Nayak
2012-06-25 5:29 ` Rajendra Nayak
2012-06-26 10:39 ` Paul Walmsley
2012-06-26 10:39 ` Paul Walmsley
2012-06-26 10:58 ` Rajendra Nayak
2012-06-26 10:58 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 09/11] iommu: " Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 10/11] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-22 13:48 ` [PATCH 11/11] ARM: omap: clk: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-06-22 13:48 ` Rajendra Nayak
2012-06-27 12:50 ` [PATCH 00/11] Prepare for OMAP2+ movement to Common Clk Laurent Pinchart
2012-06-27 12:50 ` Laurent Pinchart
2012-06-27 16:36 ` Paul Walmsley
2012-06-27 16:36 ` Paul Walmsley
2012-06-27 18:05 ` Laurent Pinchart
2012-06-27 18:05 ` Laurent Pinchart
2012-06-27 18:45 ` Laurent Pinchart
2012-06-27 18:45 ` Laurent Pinchart
2012-06-27 19:56 ` Laurent Pinchart
2012-06-27 19:56 ` Laurent Pinchart
2012-06-27 19:59 ` Paul Walmsley
2012-06-27 19:59 ` Paul Walmsley
2012-06-27 20:25 ` Laurent Pinchart
2012-06-27 20:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340604478.12683.25.camel@lappyti \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.