From: Adam Jackson <ajax@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: svenjoac@gmx.de
Subject: [PATCH 1/2] drm/edid: Be more conservative about maximum pixel clock
Date: Mon, 25 Jun 2012 11:25:18 -0400 [thread overview]
Message-ID: <1340637919-5322-2-git-send-email-ajax@redhat.com> (raw)
In-Reply-To: <1340637919-5322-1-git-send-email-ajax@redhat.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
---
drivers/gpu/drm/drm_edid.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 5873e48..4a3e61a 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1007,8 +1007,15 @@ range_pixel_clock(struct edid *edid, u8 *t)
if (edid->revision >= 4 && t[10] == 0x04)
return (t[9] * 10000) - ((t[12] >> 2) * 250);
- /* 1.3 is pathetic, so fuzz up a bit */
- return t[9] * 10000 + 5001;
+ /*
+ * Otherwise we have only 10MHz granularity. If we were using this
+ * code to filter an EDID mode list we'd want to round up like
+ * xserver does, as it's common to see a max of 160MHz but a 162MHz
+ * 1600x1200 mode as the preferred timing. But since we're using
+ * this as a filter while _building_ the list from implied support,
+ * not rounding up is the safe thing.
+ */
+ return t[9] * 10000;
}
static bool
--
1.7.7.6
next prev parent reply other threads:[~2012-06-25 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 15:25 [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes Adam Jackson
2012-06-25 15:25 ` Adam Jackson [this message]
2012-06-25 15:25 ` [PATCH 2/2] drm/edid: Be much more cautious about walking extra_modes Adam Jackson
2012-06-25 17:14 ` [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes Sven Joachim
2012-06-25 17:41 ` Adam Jackson
2012-07-20 2:03 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340637919-5322-2-git-send-email-ajax@redhat.com \
--to=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.