All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Sven Joachim <svenjoac@gmx.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes
Date: Mon, 25 Jun 2012 13:41:50 -0400	[thread overview]
Message-ID: <1340646110.11265.52.camel@atropine> (raw)
In-Reply-To: <874npz8gb7.fsf@turtle.gmx.de>


[-- Attachment #1.1: Type: text/plain, Size: 1158 bytes --]

On Mon, 2012-06-25 at 19:14 +0200, Sven Joachim wrote:
> On 2012-06-25 17:25 +0200, Adam Jackson wrote:
> 
> > This fixes the extra_mode walk to be much more conservative.  I still think
> > the whole idea is bogus and that guessing about clone mode sizes is a
> > userspace policy decision, but apparently xrandr --newmode / --addmode is
> > unreasonably burdensome.
> >
> > This should fix a number of reported regressions, please test.
> 
> Does not help in my case, unfortunately: instead of a bogus 1680x945
> resolution I get a bogus 1400x1050 rather than the correct 1280x1024.
> 
> Going to try Takashi's patch instead.

Takashi's patch will promite 1280x1024 to the default - which is correct
- but you'll still see a 1400x1050 in the mode list, because your
monitor claims a maximum pixel clock of 140MHz and maximum hsync of
81kHz, and 1400x1050@60 fits in that.

Fixing that would probably require additional quirk work to add
"preferred mode is physical pixel size".  EDID 1.4 redefines the "first
detailed mode is preferred" bit to mean that anyway, but we're not
currently using that to filter the mode list.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-06-25 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 15:25 [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes Adam Jackson
2012-06-25 15:25 ` [PATCH 1/2] drm/edid: Be more conservative about maximum pixel clock Adam Jackson
2012-06-25 15:25 ` [PATCH 2/2] drm/edid: Be much more cautious about walking extra_modes Adam Jackson
2012-06-25 17:14 ` [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes Sven Joachim
2012-06-25 17:41   ` Adam Jackson [this message]
2012-07-20  2:03     ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340646110.11265.52.camel@atropine \
    --to=ajax@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=svenjoac@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.