From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] drm/i915: don't return a spurious -EIO from intel_ring_begin
Date: Mon, 25 Jun 2012 23:52:33 +0100 [thread overview]
Message-ID: <1340664792_70515@CP5-2952> (raw)
In-Reply-To: <CAKMK7uEh7HKwWWmq+psV5Pjt3gXa+9-MwV539GAgz47shkT1gw@mail.gmail.com>
On Mon, 25 Jun 2012 23:48:01 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> So essentially I still fail to see the upside of your proposed ductape
> ... In either case I guess a walk to the reset button is inevitable
> every once in a while ;-)
A false positive for declaring a GPU wedged in a situation that should
have never occurred in the first place is a recoverable and minor
inconvenience compared to locking the display and possibly the system up.
An alternative is to incorporate the deadlock detection into
i915_mutex_lock_interruptible() and make it report -EIO if it waits
longer than 10s, f.e., for the reset to complete. Then the only danger
are the few paths that do not perform the error checking lock.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-06-25 22:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 14:42 [PATCH 0/5] gpu reset improvements Daniel Vetter
2012-06-24 14:42 ` [PATCH 1/5] drm/i915: wrap up gt powersave enabling functions Daniel Vetter
2012-06-24 23:03 ` Eugeni Dodonov
2012-06-25 7:20 ` Daniel Vetter
2012-06-29 18:51 ` Ben Widawsky
2012-06-29 21:11 ` Daniel Vetter
2012-06-24 14:42 ` [PATCH 2/5] drm/i915: make enable/disable_gt_powersave locking consistent Daniel Vetter
2012-06-24 23:03 ` Eugeni Dodonov
2012-06-25 19:08 ` Daniel Vetter
2012-06-24 14:42 ` [PATCH 3/5] drm/i915: don't return a spurious -EIO from intel_ring_begin Daniel Vetter
2012-06-25 20:32 ` Chris Wilson
2012-06-25 20:49 ` Daniel Vetter
2012-06-25 21:06 ` Chris Wilson
2012-06-25 21:48 ` Daniel Vetter
2012-06-25 22:52 ` Chris Wilson [this message]
2012-06-25 23:05 ` Daniel Vetter
2012-06-26 9:30 ` Chris Wilson
2012-06-24 14:42 ` [PATCH 4/5] drm/i915: don't trylock in the gpu reset code Daniel Vetter
2012-06-25 20:10 ` Chris Wilson
2012-06-24 14:42 ` [PATCH 5/5] drm/i915: non-interruptible sleeps can't handle -EGAIN Daniel Vetter
2012-06-25 20:23 ` Chris Wilson
2012-06-25 20:35 ` Daniel Vetter
2012-06-25 20:24 ` [PATCH] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340664792_70515@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.