From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/5] drm/i915: make enable/disable_gt_powersave locking consistent
Date: Sun, 24 Jun 2012 20:03:37 -0300 [thread overview]
Message-ID: <4FE79CC9.6010403@linux.intel.com> (raw)
In-Reply-To: <1340548956-4097-3-git-send-email-daniel.vetter@ffwll.ch>
On 06/24/2012 11:42 AM, Daniel Vetter wrote:
> The enable functions grabbed dev->struct_mutex themselves, whereas
> the disable functions expected dev->struct_mutex to be held by the
> caller. Move the locking out to the (currently only) callsite of
> intel_enable_gt_powersave to make this more consistent.
>
> Originally this was prep work for future patches, but I've chased down
> a totally wrong alley. Still, I think this is a sensible
> clarification.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Eugeni
next prev parent reply other threads:[~2012-06-24 23:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 14:42 [PATCH 0/5] gpu reset improvements Daniel Vetter
2012-06-24 14:42 ` [PATCH 1/5] drm/i915: wrap up gt powersave enabling functions Daniel Vetter
2012-06-24 23:03 ` Eugeni Dodonov
2012-06-25 7:20 ` Daniel Vetter
2012-06-29 18:51 ` Ben Widawsky
2012-06-29 21:11 ` Daniel Vetter
2012-06-24 14:42 ` [PATCH 2/5] drm/i915: make enable/disable_gt_powersave locking consistent Daniel Vetter
2012-06-24 23:03 ` Eugeni Dodonov [this message]
2012-06-25 19:08 ` Daniel Vetter
2012-06-24 14:42 ` [PATCH 3/5] drm/i915: don't return a spurious -EIO from intel_ring_begin Daniel Vetter
2012-06-25 20:32 ` Chris Wilson
2012-06-25 20:49 ` Daniel Vetter
2012-06-25 21:06 ` Chris Wilson
2012-06-25 21:48 ` Daniel Vetter
2012-06-25 22:52 ` Chris Wilson
2012-06-25 23:05 ` Daniel Vetter
2012-06-26 9:30 ` Chris Wilson
2012-06-24 14:42 ` [PATCH 4/5] drm/i915: don't trylock in the gpu reset code Daniel Vetter
2012-06-25 20:10 ` Chris Wilson
2012-06-24 14:42 ` [PATCH 5/5] drm/i915: non-interruptible sleeps can't handle -EGAIN Daniel Vetter
2012-06-25 20:23 ` Chris Wilson
2012-06-25 20:35 ` Daniel Vetter
2012-06-25 20:24 ` [PATCH] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE79CC9.6010403@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.