All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: Eliad Peller <eliad@wizery.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: mac80211 auth/assoc in multi-channel scenarios
Date: Wed, 27 Jun 2012 16:38:10 +0200	[thread overview]
Message-ID: <1340807890.11012.43.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CA+XVXfcNpj_UqCOXUG7sr2MQH8qZNHYr7MfBz5J3vwC3f+KU6Q@mail.gmail.com> (sfid-20120627_132722_460723_7FBDB1C9)

On Wed, 2012-06-27 at 14:27 +0300, Arik Nemtsov wrote:
> On Wed, Jun 27, 2012 at 2:17 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Tue, 2012-06-26 at 14:35 +0300, Arik Nemtsov wrote:
> >
> >> Can you give a bit more info on the Tx-sync approach, for the uninitiated?
> >> I'm also thinking that maybe we could somehow treat the sleeping-GO as
> >> a special case (maybe with some special code and a HW flag). Right now
> >> I'm not sure the wl12xx FW even supports it.
> >
> > I basically had a simpler version in mind, something like this:
> > http://p.sipsolutions.net/cd928e926a941ac7.txt
> 
> If the low level driver has to prepare for each such Tx, that's fine.

If it doesn't, then it can de-duplicate itself I guess? And it can also
abort everything (if needed) when the bssid is cleared (failure) or when
we go into associated (success), so I didn't add an explicit cancel
operation.

> But does this somehow rely on the timing of the Tx? Relying on op_tx
> to come right after this seems racy.

It'll depend on the driver I guess? If you're going to set a flag "give
this vif priority now" on the first invocation, then you probably
wouldn't care about the timing. It looks like our implementation would
actually start some "give me the channel" operation and when the
firmware says "ok you have the channel now" we'd return and rely on
getting the TX right after.

Wrt. the race, this isn't going to be something that happens within less
than a millisecond or so, it's going to give us maybe 50ms at least of
channel time (WFA mandates replying within 30ms), so that doesn't seem
like a problem?

johannes


  reply	other threads:[~2012-06-27 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 16:05 mac80211 auth/assoc in multi-channel scenarios Johannes Berg
2012-06-26 10:09 ` Eliad Peller
2012-06-26 10:41   ` Johannes Berg
2012-06-26 11:18     ` Eliad Peller
2012-06-26 11:35       ` Arik Nemtsov
2012-06-26 13:10         ` Johannes Berg
2012-06-26 18:18           ` Arik Nemtsov
2012-06-27  7:00             ` Johannes Berg
2012-06-27 11:17         ` Johannes Berg
2012-06-27 11:27           ` Arik Nemtsov
2012-06-27 14:38             ` Johannes Berg [this message]
2012-06-27 15:20               ` Arik Nemtsov
2012-06-27 15:25                 ` Johannes Berg
2012-06-27 17:05                   ` Arik Nemtsov
2012-06-28  9:33                     ` Johannes Berg
2012-06-28 10:01                       ` Arik Nemtsov
2012-06-28 10:10                         ` Johannes Berg
2012-06-28 12:00                           ` Arik Nemtsov
2012-06-26 12:55       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340807890.11012.43.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arik@wizery.com \
    --cc=eliad@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.