From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: Eliad Peller <eliad@wizery.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: mac80211 auth/assoc in multi-channel scenarios
Date: Thu, 28 Jun 2012 11:33:16 +0200 [thread overview]
Message-ID: <1340875996.4491.29.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CA+XVXffKSEL6ZQPQ98x-zO-NL2=TNF1uN==mprRyUmAaRn254g@mail.gmail.com> (sfid-20120627_190553_569348_1D8F81B7)
On Wed, 2012-06-27 at 20:05 +0300, Arik Nemtsov wrote:
> > Yeah, that was one of the other options I considered in my original
> > email ... but this call must be able to sleep, and the TX processing in
> > mac80211 cannot sleep, so unless we bypass all processing (which seems
> > wrong) that would be rather difficult to implement.
>
> Good point. But another race to consider the the
> multi-channel/multi-vif scenario, where the driver already has a lot
> of packets queued up, so the time will expire before we get a chance
> to Tx. Again this is not a problem in practice (since it's the VO ac).
If the vif is on a different channel, the driver really should assign it
different queues and then there shouldn't be much queued up, right?
Also, if you really have >100ms latency on your queues, you have a major
problem anyway I'd think?
> How about somehow requiring a multi channel driver to give always
> Tx-ack? That will mean we can abandon the retry timers, and rely on
> the driver to give an answer within a reasonable time.
That doesn't mean we can abandon the retry timers though? Then again,
maybe it does, we could start the timer only when we get the status
information I guess?
I'm not sure I'd want to *require* this, but it sounds like a good thing
we could do to address this possible race for drivers that do support
reliable status reports?
johannes
next prev parent reply other threads:[~2012-06-28 9:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 16:05 mac80211 auth/assoc in multi-channel scenarios Johannes Berg
2012-06-26 10:09 ` Eliad Peller
2012-06-26 10:41 ` Johannes Berg
2012-06-26 11:18 ` Eliad Peller
2012-06-26 11:35 ` Arik Nemtsov
2012-06-26 13:10 ` Johannes Berg
2012-06-26 18:18 ` Arik Nemtsov
2012-06-27 7:00 ` Johannes Berg
2012-06-27 11:17 ` Johannes Berg
2012-06-27 11:27 ` Arik Nemtsov
2012-06-27 14:38 ` Johannes Berg
2012-06-27 15:20 ` Arik Nemtsov
2012-06-27 15:25 ` Johannes Berg
2012-06-27 17:05 ` Arik Nemtsov
2012-06-28 9:33 ` Johannes Berg [this message]
2012-06-28 10:01 ` Arik Nemtsov
2012-06-28 10:10 ` Johannes Berg
2012-06-28 12:00 ` Arik Nemtsov
2012-06-26 12:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340875996.4491.29.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.