From: Artem Bityutskiy <dedekind1@gmail.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: hongxu.cn@gmail.com, richard.genoud@gmail.com,
nicolas.ferre@atmel.com, linux-mtd@lists.infradead.org,
ivan.djelic@parrot.com, computersforpeace@gmail.com,
plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 0/2] MTD: at91: Add PMECC support for at91 nand flash driver
Date: Fri, 29 Jun 2012 12:09:33 +0300 [thread overview]
Message-ID: <1340960973.3070.136.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <4FED6EAB.3000802@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
On Fri, 2012-06-29 at 17:00 +0800, Josh Wu wrote:
> > +drivers/mtd/nand/atmel_nand.c:480:32: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:488:35: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:633:32: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:635:35: error: bad constant expression [sparse]
>
> I use CodeSourcery 2010q1, and no any error reported. So it seems
> related with the compiler.
They are from sparse, not gcc.
> When I send out the next version of the patch, Could you please test it
> about above fix? since I don't have Sparse compiler in my hand. Thanks.
I will feed it to aiaiai, but you can also do it easily if you want. You
can download my maintaining scripts from here:
http://git.infradead.org/users/dedekind/maintaining.git
and there is the documentation. You can use aiaiai in general for
checking your patching before submitting out. Catches some embarrassing
errors sometimes :-)
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 0/2] MTD: at91: Add PMECC support for at91 nand flash driver
Date: Fri, 29 Jun 2012 12:09:33 +0300 [thread overview]
Message-ID: <1340960973.3070.136.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <4FED6EAB.3000802@atmel.com>
On Fri, 2012-06-29 at 17:00 +0800, Josh Wu wrote:
> > +drivers/mtd/nand/atmel_nand.c:480:32: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:488:35: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:633:32: error: bad constant expression [sparse]
> > +drivers/mtd/nand/atmel_nand.c:635:35: error: bad constant expression [sparse]
>
> I use CodeSourcery 2010q1, and no any error reported. So it seems
> related with the compiler.
They are from sparse, not gcc.
> When I send out the next version of the patch, Could you please test it
> about above fix? since I don't have Sparse compiler in my hand. Thanks.
I will feed it to aiaiai, but you can also do it easily if you want. You
can download my maintaining scripts from here:
http://git.infradead.org/users/dedekind/maintaining.git
and there is the documentation. You can use aiaiai in general for
checking your patching before submitting out. Catches some embarrassing
errors sometimes :-)
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120629/30dc8c8e/attachment.sig>
next prev parent reply other threads:[~2012-06-29 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 8:21 [PATCH v12 0/2] MTD: at91: Add PMECC support for at91 nand flash driver Josh Wu
2012-06-28 8:21 ` Josh Wu
2012-06-28 8:21 ` [PATCH v12 1/2] MTD: at91: add dt parameters for Atmel PMECC Josh Wu
2012-06-28 8:21 ` Josh Wu
2012-06-28 8:33 ` Josh Wu
2012-06-28 8:33 ` Josh Wu
2012-06-28 12:56 ` Nicolas Ferre
2012-06-28 12:56 ` Nicolas Ferre
2012-06-28 8:21 ` [PATCH v12 2/2] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-06-28 8:21 ` Josh Wu
2012-06-28 8:36 ` Nicolas Ferre
2012-06-28 8:36 ` Nicolas Ferre
2012-06-28 8:33 ` [PATCH v12 0/2] MTD: at91: Add PMECC support for at91 nand flash driver Nicolas Ferre
2012-06-28 8:33 ` Nicolas Ferre
2012-06-28 15:40 ` Artem Bityutskiy
2012-06-28 15:40 ` Artem Bityutskiy
2012-06-29 9:00 ` Josh Wu
2012-06-29 9:00 ` Josh Wu
2012-06-29 9:09 ` Artem Bityutskiy [this message]
2012-06-29 9:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340960973.3070.136.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=hongxu.cn@gmail.com \
--cc=ivan.djelic@parrot.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.