From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linux-wireless@vger.kernel.org, nbd@openwrt.org,
brcm80211-dev-list@broadcom.com, pieterpg@broadcom.com,
gregkh@suse.de, frankyl@broadcom.com, arend@broadcom.com,
rvossen@broadcom.com, brudley@broadcom.com,
linville@tuxdriver.com
Subject: Re: [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.
Date: Fri, 29 Jun 2012 15:06:50 +0200 [thread overview]
Message-ID: <1340975210.4472.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340974563-77085-1-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120629_145655_517679_6EED29D4)
On Fri, 2012-06-29 at 05:56 -0700, Thomas Huehn wrote:
> brcmsmac uses info->control.sta while doing ampdu aggregation. This patch
> changes the usage of the structure info->control.sta, as it is going to be
> removed soon from struct ieee80211_tx_info. This patch is a pre-requisit in
> order to add transmission power control (TPC) to the mac80211 subsystem.
>
> Suggested-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
> ---
> Change sequence of overwriting data. Thx to Johannes.
> @@ -665,7 +665,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
> u8 plcp0, plcp3, is40, sgi;
> struct ieee80211_sta *sta;
>
> - sta = tx_info->control.sta;
> + sta = tx_info->rate_driver_data[0];
Are you sure it actually works now?
johannes
next prev parent reply other threads:[~2012-06-29 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 12:56 [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon Thomas Huehn
2012-06-29 13:06 ` Johannes Berg [this message]
2012-06-29 15:04 ` thomas
2012-07-06 19:37 ` John W. Linville
2012-07-08 19:41 ` Arend van Spriel
2012-07-08 19:47 ` Thomas Huehn
2012-07-09 13:47 ` Arend van Spriel
2012-07-09 13:53 ` Arend van Spriel
2012-07-09 22:11 ` Thomas Huehn
2012-07-10 8:34 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 14:15 Thomas Huehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340975210.4472.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.