From: "Arend van Spriel" <arend@broadcom.com>
To: "Thomas Huehn" <thomas@net.t-labs.tu-berlin.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, nbd@openwrt.org,
brcm80211-dev-list@broadcom.com, pieterpg@broadcom.com,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
frankyl@broadcom.com, rvossen@broadcom.com, brudley@broadcom.com
Subject: Re: [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.
Date: Mon, 9 Jul 2012 15:47:35 +0200 [thread overview]
Message-ID: <4FFAE0F7.1000601@broadcom.com> (raw)
In-Reply-To: <4FF9E3E5.6080202@net.t-labs.tu-berlin.de>
On 07/08/2012 09:47 PM, Thomas Huehn wrote:
> Hi Arend,
>
> This patch has the following goal. To implement Transmission Power
> Control (TPC) in the mac80211 subsystem, I remove the STA pointer from
> the ieee_tx_info structure to gain free mem for TPC annotation and I put
> the sta on the stack to pass it to each driver function in the tx-path.
> The broadcom brcmsmac is the only driver where the ieee_tx_info is
> somewhat stored and therefore the sta point is not as straight removable
> as for the other drivers. This patch resolved that issue.
> Please have a look at my recent patch [PATCH] mac80211: Add transmit
> power control support (TPC) where I have included this one again with
> the full story in the code.
>
> Greetings Thomas
>
Hi Thomas,
I understand now. I just found the rate_driver_info somewhat obscure. I
looked into mac80211.h for the description and found that those fields
are intended for internal driver use. I will comment on the original patch.
Gr. AvS
next prev parent reply other threads:[~2012-07-09 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 12:56 [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon Thomas Huehn
2012-06-29 13:06 ` Johannes Berg
2012-06-29 15:04 ` thomas
2012-07-06 19:37 ` John W. Linville
2012-07-08 19:41 ` Arend van Spriel
2012-07-08 19:47 ` Thomas Huehn
2012-07-09 13:47 ` Arend van Spriel [this message]
2012-07-09 13:53 ` Arend van Spriel
2012-07-09 22:11 ` Thomas Huehn
2012-07-10 8:34 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 14:15 Thomas Huehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAE0F7.1000601@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.