All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: nyoushchenko@mvista.com, artem.bityutskiy@linux.intel.com,
	linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
	Heinz.Egger@linutronix.de, thomas.wucher@linutronix.de,
	linux-mtd@lists.infradead.org, shmulik.ladkani@gmail.com,
	tglx@linutronix.de, Marius.Mazarel@ugal.ro, tim.bird@am.sony.com
Subject: Re: UBI fastmap updates
Date: Sat, 30 Jun 2012 13:43:18 +0300	[thread overview]
Message-ID: <1341052998.2115.3.camel@koala> (raw)
In-Reply-To: <1340982869-77042-1-git-send-email-richard@nod.at>

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Fri, 2012-06-29 at 17:14 +0200, Richard Weinberger wrote:
> This is the next round of UBI fastmap updates.
> 
> Fastmap is now disabled by default.
> If you attach an image it will not automatically convert it
> to the fastmap format.
> UBI has a new module parameter "fm_auto".
> If set to 1 UBI will create a fastmap automatically on your
> flash device.
> Please see commit "Add a module parameter to enable fastmap"
> for more details.

One thing I've noticed is that you use vmalloc for some of the buffers
you do I/O on (fm_raw). This is a problem for many ARM platforms because
they cannot do DMA on such buffers. The drivers have to implement
various workarouns for this: either fall back to memcopies or do an
extra copy to a DMA-able buffers.

UBI and UBIFS already to I/O on vmalloc'ed buffers, an I am planning to
fix this, which is not easy. Would be great to not add more of these.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, nyoushchenko@mvista.com,
	artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org,
	adrian.hunter@intel.com, Heinz.Egger@linutronix.de,
	thomas.wucher@linutronix.de, shmulik.ladkani@gmail.com,
	tglx@linutronix.de, Marius.Mazarel@ugal.ro, tim.bird@am.sony.com
Subject: Re: UBI fastmap updates
Date: Sat, 30 Jun 2012 13:43:18 +0300	[thread overview]
Message-ID: <1341052998.2115.3.camel@koala> (raw)
In-Reply-To: <1340982869-77042-1-git-send-email-richard@nod.at>

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Fri, 2012-06-29 at 17:14 +0200, Richard Weinberger wrote:
> This is the next round of UBI fastmap updates.
> 
> Fastmap is now disabled by default.
> If you attach an image it will not automatically convert it
> to the fastmap format.
> UBI has a new module parameter "fm_auto".
> If set to 1 UBI will create a fastmap automatically on your
> flash device.
> Please see commit "Add a module parameter to enable fastmap"
> for more details.

One thing I've noticed is that you use vmalloc for some of the buffers
you do I/O on (fm_raw). This is a problem for many ARM platforms because
they cannot do DMA on such buffers. The drivers have to implement
various workarouns for this: either fall back to memcopies or do an
extra copy to a DMA-able buffers.

UBI and UBIFS already to I/O on vmalloc'ed buffers, an I am planning to
fix this, which is not easy. Would be great to not add more of these.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-06-30 10:43 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 15:14 UBI fastmap updates Richard Weinberger
2012-06-29 15:14 ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 01/11] UBI: Fastmap: Fix mem leak in error path Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 02/11] UBI: Fastmap: Amend self_check_eba() Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 03/11] UBI: Fastmap: Remove forward declaration Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 04/11] UBI: Fastmap: Move fastmap specific code into ubi_scan_fastmap() Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 05/11] UBI: Fastmap: Kill TODO Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 06/11] UBI: Fastmap: Remove unused variable Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 07/11] UBI: Fastmap: Fix scan regression Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 08/11] ubi: fastmap: Remove 'ubi' parameter of 'destroy_ai()' Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 09/11] ubi: fastmap: Do not free 'ai' in 'scan_all()' Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 10/11] UBI: Fastmap: Disable fastmap per default Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-06-29 15:14 ` [PATCH 11/11] UBI: Fastmap: Add a module parameter to enable fastmap Richard Weinberger
2012-06-29 15:14   ` Richard Weinberger
2012-07-01  6:28   ` Rusty Russell
2012-07-01  6:28     ` Rusty Russell
2012-07-01  9:41     ` Richard Weinberger
2012-07-01  9:41       ` Richard Weinberger
2012-06-30 10:43 ` Artem Bityutskiy [this message]
2012-06-30 10:43   ` UBI fastmap updates Artem Bityutskiy
2012-06-30 10:53   ` Richard Weinberger
2012-06-30 10:53     ` Richard Weinberger
2012-06-30 11:24     ` Artem Bityutskiy
2012-06-30 11:24       ` Artem Bityutskiy
2012-06-30 14:24     ` Artem Bityutskiy
2012-06-30 14:24       ` Artem Bityutskiy
2012-07-08 11:47 ` Shmulik Ladkani
2012-07-08 11:47   ` Shmulik Ladkani
2012-07-08 12:07   ` Richard Weinberger
2012-07-08 12:07     ` Richard Weinberger
2012-07-08 15:11     ` Richard Weinberger
2012-07-08 15:11       ` Richard Weinberger
2012-07-09  7:37     ` Shmulik Ladkani
2012-07-09  7:37       ` Shmulik Ladkani
2012-07-09  8:19       ` Richard Weinberger
2012-07-09  8:19         ` Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2013-09-28 13:55 Richard Weinberger
2013-10-03 16:44 ` Artem Bityutskiy
2012-07-09 12:18 Richard Weinberger
2012-07-09 12:18 ` Richard Weinberger
2012-08-02 14:12 ` Artem Bityutskiy
2012-08-02 14:12   ` Artem Bityutskiy
2012-08-02 14:15   ` Richard Weinberger
2012-08-02 14:15     ` Richard Weinberger
2012-08-02 14:29     ` Artem Bityutskiy
2012-08-02 14:29       ` Artem Bityutskiy
2012-08-02 14:51       ` Richard Weinberger
2012-08-02 14:51         ` Richard Weinberger
2012-08-02 16:17         ` Artem Bityutskiy
2012-08-02 16:17           ` Artem Bityutskiy
2012-08-02 16:32           ` Richard Weinberger
2012-08-02 16:32             ` Richard Weinberger
2012-08-02 16:45             ` Artem Bityutskiy
2012-08-02 16:45               ` Artem Bityutskiy
2012-08-02 16:54               ` Richard Weinberger
2012-08-02 16:54                 ` Richard Weinberger
2012-08-02 17:03               ` Tim Bird
2012-08-02 17:03                 ` Tim Bird
2012-08-02 17:06                 ` Richard Weinberger
2012-08-02 17:06                   ` Richard Weinberger
2012-08-02 17:40                 ` Artem Bityutskiy
2012-08-02 17:40                   ` Artem Bityutskiy
2012-08-02 17:45                   ` Richard Weinberger
2012-08-02 17:45                     ` Richard Weinberger
2012-08-02 17:59                     ` Artem Bityutskiy
2012-08-02 17:59                       ` Artem Bityutskiy
2012-08-02 18:03                       ` Richard Weinberger
2012-08-02 18:03                         ` Richard Weinberger
2012-08-02 18:15                         ` Artem Bityutskiy
2012-08-02 18:15                           ` Artem Bityutskiy
2012-08-05  8:23                     ` Shmulik Ladkani
2012-08-05  8:23                       ` Shmulik Ladkani
2012-08-05 14:25                       ` Richard Weinberger
2012-08-05 14:25                         ` Richard Weinberger
2012-08-02 17:50                 ` Artem Bityutskiy
2012-08-02 17:50                   ` Artem Bityutskiy
2012-08-02 14:58 ` Artem Bityutskiy
2012-08-02 14:58   ` Artem Bityutskiy
2012-08-02 14:59   ` Richard Weinberger
2012-08-02 14:59     ` Richard Weinberger
2012-08-02 15:18     ` Artem Bityutskiy
2012-08-02 15:18       ` Artem Bityutskiy
2012-08-02 15:19       ` Richard Weinberger
2012-08-02 15:19         ` Richard Weinberger
2012-08-06 17:36   ` Richard Weinberger
2012-08-06 17:36     ` Richard Weinberger
2012-08-07  4:21     ` Artem Bityutskiy
2012-08-07  4:21       ` Artem Bityutskiy
2012-08-07  7:29       ` Richard Weinberger
2012-08-07  7:29         ` Richard Weinberger
2012-08-07 18:53         ` Artem Bityutskiy
2012-08-07 18:53           ` Artem Bityutskiy
2012-08-02 18:50 ` Artem Bityutskiy
2012-08-02 18:50   ` Artem Bityutskiy
2012-08-02 18:56   ` Artem Bityutskiy
2012-08-02 18:56     ` Artem Bityutskiy
2012-08-03  8:47 ` Artem Bityutskiy
2012-08-03  8:47   ` Artem Bityutskiy
2012-08-03  8:56   ` Richard Weinberger
2012-08-03  8:56     ` Richard Weinberger
2012-08-17 13:11 ` Artem Bityutskiy
2012-08-17 13:11   ` Artem Bityutskiy
2012-08-17 13:33   ` Richard Weinberger
2012-08-17 13:33     ` Richard Weinberger
2012-08-17 13:41     ` Artem Bityutskiy
2012-08-17 13:41       ` Artem Bityutskiy
2012-08-17 13:43       ` Richard Weinberger
2012-08-17 13:43         ` Richard Weinberger
2012-08-17 14:06         ` Artem Bityutskiy
2012-08-17 14:06           ` Artem Bityutskiy
2012-07-02 16:23 Richard Weinberger
2012-07-02 16:23 ` Richard Weinberger
2012-06-27 15:57 Richard Weinberger
2012-06-27 15:57 ` Richard Weinberger
2012-06-23 13:03 Richard Weinberger
2012-06-23 13:03 ` Richard Weinberger
2012-06-27  4:20 ` Namjae Jeon
2012-06-27  4:20   ` Namjae Jeon
2012-06-27  6:48   ` Nikita V. Youshchenko
2012-06-27  6:48     ` Nikita V. Youshchenko
2012-06-27  7:17     ` Richard Weinberger
2012-06-27  7:17       ` Richard Weinberger
2012-06-18 16:18 UBI Fastmap updates Richard Weinberger
2012-06-18 16:18 ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341052998.2115.3.camel@koala \
    --to=dedekind1@gmail.com \
    --cc=Heinz.Egger@linutronix.de \
    --cc=Marius.Mazarel@ugal.ro \
    --cc=adrian.hunter@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nyoushchenko@mvista.com \
    --cc=richard@nod.at \
    --cc=shmulik.ladkani@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.wucher@linutronix.de \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.