From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/5] perf, x86: Enable PDIR precise instruction profiling on IvyBridge
Date: Mon, 02 Jul 2012 22:22:20 +0200 [thread overview]
Message-ID: <1341260540.23484.25.camel@twins> (raw)
In-Reply-To: <20120702195744.GG11413@one.firstfloor.org>
On Mon, 2012-07-02 at 21:57 +0200, Andi Kleen wrote:
> > Already told you no.
>
> No on what? You don't want PDIR mode? Or you don't like something
> with my implementation?
Both are crap.
If anything its an PEBS alias, we have infrastructure for that, yet you
invent new things.
You do random things like only :pp for no apparent reason.
PDIR is only supported on a single counter, regular PEBS 'instructions'
events allow for 4+ counters. Therefore a direct substitution is not
valid.
next prev parent reply other threads:[~2012-07-02 20:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 18:43 Updated and combined Sandy Bridge/Ivy Bridge perf patchkits Andi Kleen
2012-07-02 18:43 ` [PATCH 1/5] perf, x86: Improve basic Ivy Bridge support v3 Andi Kleen
2012-07-02 19:26 ` Peter Zijlstra
2012-07-02 19:58 ` Andi Kleen
2012-07-02 20:18 ` Peter Zijlstra
2012-07-02 18:43 ` [PATCH 2/5] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
2012-07-02 19:18 ` Peter Zijlstra
2012-07-02 19:57 ` Andi Kleen
2012-07-02 20:22 ` Peter Zijlstra [this message]
2012-07-02 21:00 ` Andi Kleen
2012-07-02 21:36 ` Peter Zijlstra
2012-07-02 21:57 ` Andi Kleen
2012-07-02 23:13 ` Stephane Eranian
2012-07-03 4:04 ` Andi Kleen
2012-07-05 15:45 ` Stephane Eranian
2012-07-05 17:26 ` Andi Kleen
2012-07-06 1:04 ` Stephane Eranian
2012-07-02 18:43 ` [PATCH 3/5] x86: Do microcode updates at CPU_STARTING, not CPU_ONLINE v2 Andi Kleen
2012-07-02 18:43 ` [PATCH 4/5] perf, x86: check ucode before disabling PEBS on SandyBridge v4 Andi Kleen
2012-07-02 18:43 ` [PATCH 5/5] perf, x86: Spell Romley correctly Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2012-07-02 20:40 Another IvyBridge/SandyBridge patchkit Andi Kleen
2012-07-02 20:40 ` [PATCH 2/5] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341260540.23484.25.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.