From: Johannes Berg <johannes@sipsolutions.net>
To: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas.
Date: Wed, 04 Jul 2012 11:35:28 +0200 [thread overview]
Message-ID: <1341394528.4482.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1341393221-5396-1-git-send-email-cavallar@lri.fr>
On Wed, 2012-07-04 at 11:13 +0200, Nicolas Cavallari wrote:
> When drop_unencrypted is enabled and MFP is disabled, non-robust
> management frames for not-yet associated STA are dropped before
> being transmitted.
>
> This isn't visible as many management frames sent from the kernel
> have TX_INTFL_DONT_ENCRYPT set and management frames injected from
> monitor vifs have TX_CTL_INJECTED set, so are never dropped in the
> tx path. But mgmt frames sent from userspace via NL80211_CMD_FRAME
> do not have any of these flags, so are dropped.
>
> This patch make it accept non-robust management frames,
> but drops non-management frames and robust management frames as usual.
>
> Signed-off-by: Nicolas Cavallari <cavallar@lri.fr>
>
> ---
>
> Found this while trying to manage auth frames in userspace
> on a IBSS RSN network.
> I'm a bit surprised that drop_unencrypted is disabled both
> in AP and managed mode, but only enabled in IBSS RSN, which
> does not support MFP, yet.
Hmmm. Yes, all this seems a bit messy. Can we clean this up first?
Maybe something like this?
http://p.sipsolutions.net/d68a99dd3d9b1ab1.txt
The whole drop_unencrypted seems strange to start with though...
johannes
next prev parent reply other threads:[~2012-07-04 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 9:13 [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-04 9:35 ` Johannes Berg [this message]
2012-07-04 10:03 ` Nicolas Cavallari
2012-07-04 10:12 ` Johannes Berg
2012-07-04 13:00 ` Nicolas Cavallari
2012-07-04 13:29 ` Johannes Berg
2012-07-04 16:10 ` [PATCH 1/2] mac80211: restructure key selection Nicolas Cavallari
2012-07-04 16:10 ` [PATCHv3 2/2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-10 16:07 ` [PATCH 1/2] mac80211: restructure key selection Johannes Berg
2012-07-04 13:45 ` [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-04 17:44 ` Jouni Malinen
2012-07-05 7:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341394528.4482.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Nicolas.Cavallari@lri.fr \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.