From: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas.
Date: Wed, 04 Jul 2012 12:03:05 +0200 [thread overview]
Message-ID: <4FF414D9.4060509@lri.fr> (raw)
In-Reply-To: <1341394528.4482.4.camel@jlt3.sipsolutions.net>
On 04/07/2012 11:35, Johannes Berg wrote:
> On Wed, 2012-07-04 at 11:13 +0200, Nicolas Cavallari wrote:
>> Found this while trying to manage auth frames in userspace
>> on a IBSS RSN network.
>> I'm a bit surprised that drop_unencrypted is disabled both
>> in AP and managed mode, but only enabled in IBSS RSN, which
>> does not support MFP, yet.
>
> Hmmm. Yes, all this seems a bit messy. Can we clean this up first?
The whole function is a bit messy. some clean ups would be nice
but it is too easy to break corner cases.
>
> Maybe something like this?
> http://p.sipsolutions.net/d68a99dd3d9b1ab1.txt
No problem for me. I didn't want that patch to too intrusive at first.
Do you want to apply it yourself ? or should i include it in a series ?
> The whole drop_unencrypted seems strange to start with though...
what to you find strange ? that it is not used in a ESS, or how it works
? or both ?
next prev parent reply other threads:[~2012-07-04 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 9:13 [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-04 9:35 ` Johannes Berg
2012-07-04 10:03 ` Nicolas Cavallari [this message]
2012-07-04 10:12 ` Johannes Berg
2012-07-04 13:00 ` Nicolas Cavallari
2012-07-04 13:29 ` Johannes Berg
2012-07-04 16:10 ` [PATCH 1/2] mac80211: restructure key selection Nicolas Cavallari
2012-07-04 16:10 ` [PATCHv3 2/2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-10 16:07 ` [PATCH 1/2] mac80211: restructure key selection Johannes Berg
2012-07-04 13:45 ` [PATCH v2] mac80211: tx: do not drop non-robust mgmt to non-MFP stas Nicolas Cavallari
2012-07-04 17:44 ` Jouni Malinen
2012-07-05 7:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF414D9.4060509@lri.fr \
--to=nicolas.cavallari@lri.fr \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.