From: Devendra Naga <devendra.aaru@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>,
Marek Belisko <marek.belisko@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Devendra Naga <devendra.aaru@gmail.com>
Subject: [PATCH 1/8] staging/ft1000: fix the no brace needed warning in ft1000_interrupt
Date: Sat, 7 Jul 2012 17:35:12 +0530 [thread overview]
Message-ID: <1341662719-25752-1-git-send-email-devendra.aaru@gmail.com> (raw)
as the if statement encloses only one line braces around it are not
needed.
The following warn fixed,
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index c4a8a0a..0bd080c 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -1998,9 +1998,8 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
// Make sure we process all interrupt before leaving the ISR due to the edge trigger interrupt type
while (inttype) {
- if (inttype & ISR_DOORBELL_PEND) {
- ft1000_parse_dpram_msg(dev);
- }
+ if (inttype & ISR_DOORBELL_PEND)
+ ft1000_parse_dpram_msg(dev);
if (inttype & ISR_RCV) {
DEBUG(1, "Data in FIFO\n");
--
1.7.9.5
next reply other threads:[~2012-07-07 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 12:05 Devendra Naga [this message]
2012-07-07 12:05 ` [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line Devendra Naga
2012-07-09 19:25 ` Greg KH
2012-07-07 12:05 ` [PATCH 3/8] staging/ft1000: fix sparse warning Devendra Naga
2012-07-07 12:05 ` [PATCH 4/8] staging/ft1000: fix sparse warning about the kernel thread handler function Devendra Naga
2012-07-07 12:05 ` [PATCH 5/8] staging/ft1000: fix the no brace needed warning in ft1000_read_fifo_len Devendra Naga
2012-07-07 12:05 ` [PATCH 6/8] staging/ft1000: fix the foo * bar warning Devendra Naga
2012-07-07 12:05 ` [PATCH 7/8] staging/ft1000-pcmcia: fix checkpatch warnings Devendra Naga
2012-07-07 12:05 ` [PATCH 8/8] staging/ft1000: remove unnecessary assignment of ret with STATUS_SUCCESS Devendra Naga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341662719-25752-1-git-send-email-devendra.aaru@gmail.com \
--to=devendra.aaru@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.