All of lore.kernel.org
 help / color / mirror / Atom feed
From: Devendra Naga <devendra.aaru@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>,
	Marek Belisko <marek.belisko@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Devendra Naga <devendra.aaru@gmail.com>
Subject: [PATCH 5/8] staging/ft1000: fix the no brace needed warning in ft1000_read_fifo_len
Date: Sat,  7 Jul 2012 17:35:16 +0530	[thread overview]
Message-ID: <1341662719-25752-5-git-send-email-devendra.aaru@gmail.com> (raw)
In-Reply-To: <1341662719-25752-1-git-send-email-devendra.aaru@gmail.com>

as the if else statements enclose only one line, so braces around them are not
needed.

The following warning is fixed

drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:100: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index c709671..67ad7ee 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -97,11 +97,10 @@ static inline u16 ft1000_read_fifo_len(struct net_device *dev)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 
-	if (info->AsicID == ELECTRABUZZ_ID) {
+	if (info->AsicID == ELECTRABUZZ_ID)
 		return (ft1000_read_reg(dev, FT1000_REG_UFIFO_STAT) - 16);
-	} else {
+	else
 		return (ft1000_read_reg(dev, FT1000_REG_MAG_UFSR) - 16);
-	}
 }
 
 //---------------------------------------------------------------------------
-- 
1.7.9.5


  parent reply	other threads:[~2012-07-07 12:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-07 12:05 [PATCH 1/8] staging/ft1000: fix the no brace needed warning in ft1000_interrupt Devendra Naga
2012-07-07 12:05 ` [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line Devendra Naga
2012-07-09 19:25   ` Greg KH
2012-07-07 12:05 ` [PATCH 3/8] staging/ft1000: fix sparse warning Devendra Naga
2012-07-07 12:05 ` [PATCH 4/8] staging/ft1000: fix sparse warning about the kernel thread handler function Devendra Naga
2012-07-07 12:05 ` Devendra Naga [this message]
2012-07-07 12:05 ` [PATCH 6/8] staging/ft1000: fix the foo * bar warning Devendra Naga
2012-07-07 12:05 ` [PATCH 7/8] staging/ft1000-pcmcia: fix checkpatch warnings Devendra Naga
2012-07-07 12:05 ` [PATCH 8/8] staging/ft1000: remove unnecessary assignment of ret with STATUS_SUCCESS Devendra Naga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341662719-25752-5-git-send-email-devendra.aaru@gmail.com \
    --to=devendra.aaru@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.