[alsa-utils] [PATCH 1/3] aplay: Fix signal.h include

[alsa-utils] [PATCH 1/3] aplay: Fix signal.h include

[Arun Raghavan]

The correct header to include is <signal.h> not <sys/signal.h>.
---
 aplay/aplay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/aplay/aplay.c b/aplay/aplay.c
index 8462484..932497d 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -42,10 +42,10 @@
 #include <alsa/asoundlib.h>
 #include <assert.h>
 #include <termios.h>
+#include <signal.h>
 #include <sys/poll.h>
 #include <sys/uio.h>
 #include <sys/time.h>
-#include <sys/signal.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <endian.h>
-- 
1.7.8.6

[alsa-utils] [PATCH 2/3] aplay: Use open() instead of open64()

[Arun Raghavan]

AC_SYS_LARGEFILE in configure.in will automatically set up defines so
that open() will support large files if supported, and if not, this
allows us to fall back gracefully to non-LFS open().
---
 aplay/aplay.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/aplay/aplay.c b/aplay/aplay.c
index 932497d..17fa913 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -2499,7 +2499,7 @@ static void playback(char *name)
 		name = "stdin";
 	} else {
 		init_stdin();
-		if ((fd = open64(name, O_RDONLY, 0)) == -1) {
+		if ((fd = open(name, O_RDONLY, 0)) == -1) {
 			perror(name);
 			prg_exit(EXIT_FAILURE);
 		}
@@ -2707,12 +2707,12 @@ static int safe_open(const char *name)
 {
 	int fd;
 
-	fd = open64(name, O_WRONLY | O_CREAT, 0644);
+	fd = open(name, O_WRONLY | O_CREAT, 0644);
 	if (fd == -1) {
 		if (errno != ENOENT || !use_strftime)
 			return -1;
 		if (create_path(name) == 0)
-			fd = open64(name, O_WRONLY | O_CREAT, 0644);
+			fd = open(name, O_WRONLY | O_CREAT, 0644);
 	}
 	return fd;
 }
-- 
1.7.8.6

[alsa-utils] [PATCH 3/3] build: Don't call AC_CHECK_FUNC with --disable-alsatest

[Arun Raghavan]

---
 configure.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/configure.in b/configure.in
index e7bb4ca..6888dae 100644
--- a/configure.in
+++ b/configure.in
@@ -31,8 +31,10 @@ AC_PROG_LN_S
 AC_PROG_SED
 PKG_PROG_PKG_CONFIG
 AM_PATH_ALSA(1.0.24)
+if test "x$enable_alsatest" = "xyes"; then
 AC_CHECK_FUNC([snd_ctl_elem_add_enumerated],
 	      , [AC_ERROR([No user enum control support in alsa-lib])])
+fi
 
 dnl Check components
 AC_CHECK_HEADERS([alsa/pcm.h], [have_pcm="yes"], [have_pcm="no"],
-- 
1.7.8.6

Re: [alsa-utils] [PATCH 1/3] aplay: Fix signal.h include

[Takashi Iwai]

At Tue, 17 Jul 2012 15:45:33 +0530,
Arun Raghavan wrote:
> 
> The correct header to include is <signal.h> not <sys/signal.h>.

Applied all now despite of lack of sign-off, as these are so trivial
patches.


thanks,

Takashi

> ---
>  aplay/aplay.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/aplay/aplay.c b/aplay/aplay.c
> index 8462484..932497d 100644
> --- a/aplay/aplay.c
> +++ b/aplay/aplay.c
> @@ -42,10 +42,10 @@
>  #include <alsa/asoundlib.h>
>  #include <assert.h>
>  #include <termios.h>
> +#include <signal.h>
>  #include <sys/poll.h>
>  #include <sys/uio.h>
>  #include <sys/time.h>
> -#include <sys/signal.h>
>  #include <sys/stat.h>
>  #include <sys/types.h>
>  #include <endian.h>
> -- 
> 1.7.8.6
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

Re: [alsa-utils] [PATCH 1/3] aplay: Fix signal.h include

[Arun Raghavan]

On Tue, 2012-07-17 at 15:11 +0200, Takashi Iwai wrote:
> At Tue, 17 Jul 2012 15:45:33 +0530,
> Arun Raghavan wrote:
> > 
> > The correct header to include is <signal.h> not <sys/signal.h>.
> 
> Applied all now despite of lack of sign-off, as these are so trivial
> patches.

Thanks! Will try to make sure I don't forget in the future.

-- Arun