All of lore.kernel.org
 help / color / mirror / Atom feed
From: initcrash@gmail.com
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Christian Schilling <initcrash@gmail.com>
Subject: [Qemu-trivial] [PATCH] eepro100: fix simplified mode
Date: Mon, 23 Jul 2012 11:25:44 +0200	[thread overview]
Message-ID: <1343035544-11101-1-git-send-email-initcrash@gmail.com> (raw)

From: Christian Schilling <initcrash@gmail.com>

A driver using simplified mode that works on real hardware
did not work in qemu.

Signed-off-by: Christian Schilling <initcrash@gmail.com>
---
 hw/eepro100.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/hw/eepro100.c b/hw/eepro100.c
index 6279ae3..4a48372 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -774,6 +774,13 @@ static void tx_command(EEPRO100State *s)
 #if 0
         uint16_t tx_buffer_el = lduw_le_pci_dma(&s->dev, tbd_address + 6);
 #endif
+        if (tbd_array == 0xffffffff) {
+            /* In simpliyfied mode there is no tbd_array. Instead the packet data
+             * starts right after the tcb_bytes field, and the packet size is
+             * equal to tcb_bytes */
+            tx_buffer_size = tcb_bytes;
+            tx_buffer_address = tbd_address;
+        }
         tbd_address += 8;
         TRACE(RXTX, logout
             ("TBD (simplified mode): buffer address 0x%08x, size 0x%04x\n",
-- 
1.7.7.6



WARNING: multiple messages have this Message-ID (diff)
From: initcrash@gmail.com
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Christian Schilling <initcrash@gmail.com>
Subject: [Qemu-devel] [PATCH] eepro100: fix simplified mode
Date: Mon, 23 Jul 2012 11:25:44 +0200	[thread overview]
Message-ID: <1343035544-11101-1-git-send-email-initcrash@gmail.com> (raw)

From: Christian Schilling <initcrash@gmail.com>

A driver using simplified mode that works on real hardware
did not work in qemu.

Signed-off-by: Christian Schilling <initcrash@gmail.com>
---
 hw/eepro100.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/hw/eepro100.c b/hw/eepro100.c
index 6279ae3..4a48372 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -774,6 +774,13 @@ static void tx_command(EEPRO100State *s)
 #if 0
         uint16_t tx_buffer_el = lduw_le_pci_dma(&s->dev, tbd_address + 6);
 #endif
+        if (tbd_array == 0xffffffff) {
+            /* In simpliyfied mode there is no tbd_array. Instead the packet data
+             * starts right after the tcb_bytes field, and the packet size is
+             * equal to tcb_bytes */
+            tx_buffer_size = tcb_bytes;
+            tx_buffer_address = tbd_address;
+        }
         tbd_address += 8;
         TRACE(RXTX, logout
             ("TBD (simplified mode): buffer address 0x%08x, size 0x%04x\n",
-- 
1.7.7.6

             reply	other threads:[~2012-07-23  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23  9:25 initcrash [this message]
2012-07-23  9:25 ` [Qemu-devel] [PATCH] eepro100: fix simplified mode initcrash
2012-07-23 16:28 ` [Qemu-trivial] " Stefan Weil
2012-07-23 16:28   ` Stefan Weil
2012-07-24  7:49   ` christian schilling
2013-09-27 10:02     ` Paolo Bonzini
2013-09-27 16:43       ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343035544-11101-1-git-send-email-initcrash@gmail.com \
    --to=initcrash@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.