All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
	ilw@linux.intel.com, users@rt2x00.serialmonkey.com,
	b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com,
	chunkeey@googlemail.com, buytenh@wantstofly.org, dsd@gentoo.org,
	coelho@ti.com, nbd@openwrt.org
Subject: [PATCH v6] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Thu, 26 Jul 2012 18:17:33 +0200	[thread overview]
Message-ID: <1343319453.4477.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1343318961-46933-1-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120726_180930_993025_AB3D0B96)

On Thu, 2012-07-26 at 18:09 +0200, Thomas Huehn wrote:
> The pointer control.sta is removed from ieee80211_tx_info to free up
> sufficient memory in SKB_CB on the tx-path to enable new annotations
> per data packet e.g.support of upcoming Transmit Power Control (TPC).
> Now the control.sta pointer is put on the stack where passed as
> function parameter to the .tx equivalent (ieee80211_ops) of each
> affected wireless driver.
> Therefore a new structure ieee80211_tx_control is added to mac80211.h
> which holds the sta structure instead. The tx-path of all affected
> drivers is restructured to respect the chaneges.

*sigh*

/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ?wl1271_skb_queue_head?:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:622:48:
warning: ?hlid? may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ?wlcore_tx_work_locked?:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:391:47:
warning: ?hlid? may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:351:5:
note: ?hlid? was declared here


johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v6] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Thu, 26 Jul 2012 18:17:33 +0200	[thread overview]
Message-ID: <1343319453.4477.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1343318961-46933-1-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120726_180930_993025_AB3D0B96)

On Thu, 2012-07-26 at 18:09 +0200, Thomas Huehn wrote:
> The pointer control.sta is removed from ieee80211_tx_info to free up
> sufficient memory in SKB_CB on the tx-path to enable new annotations
> per data packet e.g.support of upcoming Transmit Power Control (TPC).
> Now the control.sta pointer is put on the stack where passed as
> function parameter to the .tx equivalent (ieee80211_ops) of each
> affected wireless driver.
> Therefore a new structure ieee80211_tx_control is added to mac80211.h
> which holds the sta structure instead. The tx-path of all affected
> drivers is restructured to respect the chaneges.

*sigh*

/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ?wl1271_skb_queue_head?:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:622:48:
warning: ?hlid? may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ?wlcore_tx_work_locked?:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:391:47:
warning: ?hlid? may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:351:5:
note: ?hlid? was declared here


johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
	ilw@linux.intel.com, users@rt2x00.serialmonkey.com,
	b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com,
	chunkeey@googlemail.com, buytenh@wantstofly.org, dsd@gentoo.org,
	coelho@ti.com, nbd@openwrt.org
Subject: Re: [PATCH v6] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Thu, 26 Jul 2012 18:17:33 +0200	[thread overview]
Message-ID: <1343319453.4477.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1343318961-46933-1-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120726_180930_993025_AB3D0B96)

On Thu, 2012-07-26 at 18:09 +0200, Thomas Huehn wrote:
> The pointer control.sta is removed from ieee80211_tx_info to free up
> sufficient memory in SKB_CB on the tx-path to enable new annotations
> per data packet e.g.support of upcoming Transmit Power Control (TPC).
> Now the control.sta pointer is put on the stack where passed as
> function parameter to the .tx equivalent (ieee80211_ops) of each
> affected wireless driver.
> Therefore a new structure ieee80211_tx_control is added to mac80211.h
> which holds the sta structure instead. The tx-path of all affected
> drivers is restructured to respect the chaneges.

*sigh*

/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ‘wl1271_skb_queue_head’:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:622:48:
warning: ‘hlid’ may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
function ‘wlcore_tx_work_locked’:
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:391:47:
warning: ‘hlid’ may be used uninitialized in this function
[-Wuninitialized]
/home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:351:5:
note: ‘hlid’ was declared here


johannes


  reply	other threads:[~2012-07-26 16:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 16:09 [PATCH v6] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path Thomas Huehn
2012-07-26 16:09 ` [ath9k-devel] " Thomas Huehn
2012-07-26 16:17 ` Johannes Berg [this message]
2012-07-26 16:17   ` Johannes Berg
2012-07-26 16:17   ` [ath9k-devel] " Johannes Berg
2012-07-26 16:19   ` Johannes Berg
2012-07-26 16:19     ` Johannes Berg
2012-07-26 16:19     ` [ath9k-devel] " Johannes Berg
2012-07-26 16:31     ` Thomas Huehn
2012-07-26 16:31       ` Thomas Huehn
2012-07-26 16:31       ` [ath9k-devel] " Thomas Huehn
2012-07-26 16:46       ` Johannes Berg
2012-07-26 16:57       ` Arik Nemtsov
2012-07-26 16:57         ` Arik Nemtsov
2012-07-26 16:57         ` [ath9k-devel] " Arik Nemtsov
2012-07-26 17:04         ` Arik Nemtsov
2012-07-26 17:04           ` Arik Nemtsov
2012-07-26 17:04           ` [ath9k-devel] " Arik Nemtsov
2012-07-26 18:41           ` Arik Nemtsov
2012-07-26 18:41             ` Arik Nemtsov
2012-07-26 18:41             ` [ath9k-devel] " Arik Nemtsov
2012-07-26 20:02             ` Thomas Huehn
2012-07-26 20:02               ` Thomas Huehn
2012-07-26 20:02               ` [ath9k-devel] " Thomas Huehn
2012-07-27  7:26               ` Johannes Berg
2012-07-27  7:26                 ` Johannes Berg
2012-07-27  7:26                 ` [ath9k-devel] " Johannes Berg
2012-07-27  9:35                 ` Thomas Huehn
2012-07-27  9:35                   ` Thomas Huehn
2012-07-27  9:35                   ` [ath9k-devel] " Thomas Huehn
2012-07-27 11:52                   ` Johannes Berg
2012-07-27 11:52                     ` Johannes Berg
2012-07-27 11:52                     ` [ath9k-devel] " Johannes Berg
2012-07-27 13:28                     ` Thomas Huehn
2012-07-27 13:28                       ` Thomas Huehn
2012-07-27 13:28                       ` [ath9k-devel] " Thomas Huehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343319453.4477.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=b43-dev@lists.infradead.org \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=buytenh@wantstofly.org \
    --cc=chunkeey@googlemail.com \
    --cc=coelho@ti.com \
    --cc=dsd@gentoo.org \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    --cc=thomas@net.t-labs.tu-berlin.de \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.