* [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
@ 2012-08-03 22:42 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2012-08-03 22:42 UTC (permalink / raw)
To: linux-arm-kernel
Now that ARM has implemented its spinlocks with tickets we don't
need to use the generic lockbreak algorithm. Remove the Kconfig
from ARM so that we use the arch_spin_is_contended() definition
from the asm header. This also saves a word in each lock because
we don't need the break_lock member anymore.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
It seems we define the arch_spin_is_contended() macro but we don't
use it on SMP && PREEMPT kernels?
arch/arm/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e91c7cd..e4191cc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -126,11 +126,6 @@ config TRACE_IRQFLAGS_SUPPORT
bool
default y
-config GENERIC_LOCKBREAK
- bool
- default y
- depends on SMP && PREEMPT
-
config RWSEM_GENERIC_SPINLOCK
bool
default y
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
@ 2012-08-03 22:42 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2012-08-03 22:42 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-arm-kernel
Now that ARM has implemented its spinlocks with tickets we don't
need to use the generic lockbreak algorithm. Remove the Kconfig
from ARM so that we use the arch_spin_is_contended() definition
from the asm header. This also saves a word in each lock because
we don't need the break_lock member anymore.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
It seems we define the arch_spin_is_contended() macro but we don't
use it on SMP && PREEMPT kernels?
arch/arm/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e91c7cd..e4191cc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -126,11 +126,6 @@ config TRACE_IRQFLAGS_SUPPORT
bool
default y
-config GENERIC_LOCKBREAK
- bool
- default y
- depends on SMP && PREEMPT
-
config RWSEM_GENERIC_SPINLOCK
bool
default y
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
2012-08-03 22:42 ` Stephen Boyd
@ 2012-08-05 13:20 ` Will Deacon
-1 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2012-08-05 13:20 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 03, 2012 at 11:42:42PM +0100, Stephen Boyd wrote:
> Now that ARM has implemented its spinlocks with tickets we don't
> need to use the generic lockbreak algorithm. Remove the Kconfig
> from ARM so that we use the arch_spin_is_contended() definition
> from the asm header. This also saves a word in each lock because
> we don't need the break_lock member anymore.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> It seems we define the arch_spin_is_contended() macro but we don't
> use it on SMP && PREEMPT kernels?
Thanks, I missed that.
Acked-by: Will Deacon <will.deacon@arm.com>
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
@ 2012-08-05 13:20 ` Will Deacon
0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2012-08-05 13:20 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Fri, Aug 03, 2012 at 11:42:42PM +0100, Stephen Boyd wrote:
> Now that ARM has implemented its spinlocks with tickets we don't
> need to use the generic lockbreak algorithm. Remove the Kconfig
> from ARM so that we use the arch_spin_is_contended() definition
> from the asm header. This also saves a word in each lock because
> we don't need the break_lock member anymore.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> It seems we define the arch_spin_is_contended() macro but we don't
> use it on SMP && PREEMPT kernels?
Thanks, I missed that.
Acked-by: Will Deacon <will.deacon@arm.com>
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-05 13:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-03 22:42 [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks Stephen Boyd
2012-08-03 22:42 ` Stephen Boyd
2012-08-05 13:20 ` Will Deacon
2012-08-05 13:20 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.