From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup desired rps frequency computation
Date: Wed, 08 Aug 2012 21:12:21 +0100 [thread overview]
Message-ID: <1344456739_60463@CP5-2952> (raw)
In-Reply-To: <1344440572-12411-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 8 Aug 2012 17:42:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> In commit
>
> commit 20b46e59dd102665ce7168baa215e5b1ee66b69b
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Thu Jul 26 11:16:14 2012 +0200
>
> drm/i915: Only set the down rps limit when at the loweset frequency
>
> The computation for the new desired frequency was extracted, but since
> the desired frequency was passed-by value, the adjustments didn't
> propgate back. Fix this.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Ouch, how embarrassing - for the reviewer. :(
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-08-08 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 15:42 [PATCH] drm/i915: fixup desired rps frequency computation Daniel Vetter
2012-08-08 20:12 ` Chris Wilson [this message]
2012-08-08 20:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344456739_60463@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.