From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: marex@denx.de, fabio.estevam@freescale.com, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, shawn.guo@linaro.org,
Huang Shijie <shijie8@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] mtd: gpmi: add NAND write verify support
Date: Mon, 13 Aug 2012 13:20:27 +0300 [thread overview]
Message-ID: <1344853227.3393.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <50288C0E.5060400@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On Mon, 2012-08-13 at 13:09 +0800, Huang Shijie wrote:
> 于 2012年08月13日 12:44, Artem Bityutskiy 写道:
> > On Sat, Aug 11, 2012 at 6:25 PM, Huang Shijie<shijie8@gmail.com> wrote:
> >> Add NAND write verify support in gpmi-nand driver.
> >>
> >> This patch fixes a kernel crash when we select
> >> CONFIG_MTD_NAND_VERIFY_WRITE=y, and do some write tests:
> > I would just kill ONFIG_MTD_NAND_VERIFY_WRITE entirely. Some drivers
> > do not support it and it does not work for sub-pages for long time.
> > Both UBI and JFFS2 are able to read verify what they wrote already.
> > There are also MTD tests which do this verification. So I think there
> > is no reason to keep this in the NAND layer, let alone wasting RAM in
> > the driver to support this feature.
> >
> > I am also removing the -stable mailing list - ne need to spam it.
> >
> thanks a lot. Maybe we should send a patch to remove the
> CONFIG_MTD_NAND_VERIFY_WRITE feature entirely.
I'd suggest that instead. I have huge back-log, so wouldn't be able to
process it quickly, but at some point I would take it to the l2 tree.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd: gpmi: add NAND write verify support
Date: Mon, 13 Aug 2012 13:20:27 +0300 [thread overview]
Message-ID: <1344853227.3393.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <50288C0E.5060400@freescale.com>
On Mon, 2012-08-13 at 13:09 +0800, Huang Shijie wrote:
> ? 2012?08?13? 12:44, Artem Bityutskiy ??:
> > On Sat, Aug 11, 2012 at 6:25 PM, Huang Shijie<shijie8@gmail.com> wrote:
> >> Add NAND write verify support in gpmi-nand driver.
> >>
> >> This patch fixes a kernel crash when we select
> >> CONFIG_MTD_NAND_VERIFY_WRITE=y, and do some write tests:
> > I would just kill ONFIG_MTD_NAND_VERIFY_WRITE entirely. Some drivers
> > do not support it and it does not work for sub-pages for long time.
> > Both UBI and JFFS2 are able to read verify what they wrote already.
> > There are also MTD tests which do this verification. So I think there
> > is no reason to keep this in the NAND layer, let alone wasting RAM in
> > the driver to support this feature.
> >
> > I am also removing the -stable mailing list - ne need to spam it.
> >
> thanks a lot. Maybe we should send a patch to remove the
> CONFIG_MTD_NAND_VERIFY_WRITE feature entirely.
I'd suggest that instead. I have huge back-log, so wouldn't be able to
process it quickly, but at some point I would take it to the l2 tree.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120813/b1312dac/attachment.sig>
next prev parent reply other threads:[~2012-08-13 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 15:25 [PATCH v2] mtd: gpmi: add NAND write verify support Huang Shijie
2012-08-11 15:25 ` Huang Shijie
2012-08-11 3:37 ` Huang Shijie
2012-08-11 3:37 ` Huang Shijie
2012-08-13 4:44 ` Artem Bityutskiy
2012-08-13 4:44 ` Artem Bityutskiy
2012-08-13 5:09 ` Huang Shijie
2012-08-13 5:09 ` Huang Shijie
2012-08-13 10:20 ` Artem Bityutskiy [this message]
2012-08-13 10:20 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344853227.3393.7.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.