All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org,
	pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org,
	kay.sievers-tD+1rO4QERM@public.gmane.org
Subject: Re: [RFC 0/5] forced comounts for cgroups.
Date: Wed, 05 Sep 2012 12:20:53 +0200	[thread overview]
Message-ID: <1346840453.2461.6.camel@laptop> (raw)
In-Reply-To: <50471C0C.7050600-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>

On Wed, 2012-09-05 at 13:31 +0400, Glauber Costa wrote:
> 
> You wouldn't have to do more than one hierarchy walks for that. What
> Tejun seems to want, is the ability to not have a particular controller
> at some point in the tree. But if they exist, they are always together. 

Right, but the accounting is very much tied to the control structures, I
suppose we could change that, but my jet-leg addled brain isn't seeing
anything particularly nice atm.

But I don't really see the point though, this kind of interface would
only ever work for the non-controlling and controlling controller
combination (confused yet ;-), and I don't think we have many of those.

I would really rather see a simplification of the entire cgroup
interface space as opposed to making it more complex. And adding this
subtree 'feature' only makes it more complex.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Glauber Costa <glommer@parallels.com>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, davej@redhat.com, ben@decadent.org.uk,
	pjt@google.com, lennart@poettering.net, kay.sievers@vrfy.org
Subject: Re: [RFC 0/5] forced comounts for cgroups.
Date: Wed, 05 Sep 2012 12:20:53 +0200	[thread overview]
Message-ID: <1346840453.2461.6.camel@laptop> (raw)
In-Reply-To: <50471C0C.7050600@parallels.com>

On Wed, 2012-09-05 at 13:31 +0400, Glauber Costa wrote:
> 
> You wouldn't have to do more than one hierarchy walks for that. What
> Tejun seems to want, is the ability to not have a particular controller
> at some point in the tree. But if they exist, they are always together. 

Right, but the accounting is very much tied to the control structures, I
suppose we could change that, but my jet-leg addled brain isn't seeing
anything particularly nice atm.

But I don't really see the point though, this kind of interface would
only ever work for the non-controlling and controlling controller
combination (confused yet ;-), and I don't think we have many of those.

I would really rather see a simplification of the entire cgroup
interface space as opposed to making it more complex. And adding this
subtree 'feature' only makes it more complex.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Glauber Costa <glommer@parallels.com>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, davej@redhat.com, ben@decadent.org.uk,
	pjt@google.com, lennart@poettering.net, kay.sievers@vrfy.org
Subject: Re: [RFC 0/5] forced comounts for cgroups.
Date: Wed, 05 Sep 2012 12:20:53 +0200	[thread overview]
Message-ID: <1346840453.2461.6.camel@laptop> (raw)
In-Reply-To: <50471C0C.7050600@parallels.com>

On Wed, 2012-09-05 at 13:31 +0400, Glauber Costa wrote:
> 
> You wouldn't have to do more than one hierarchy walks for that. What
> Tejun seems to want, is the ability to not have a particular controller
> at some point in the tree. But if they exist, they are always together. 

Right, but the accounting is very much tied to the control structures, I
suppose we could change that, but my jet-leg addled brain isn't seeing
anything particularly nice atm.

But I don't really see the point though, this kind of interface would
only ever work for the non-controlling and controlling controller
combination (confused yet ;-), and I don't think we have many of those.

I would really rather see a simplification of the entire cgroup
interface space as opposed to making it more complex. And adding this
subtree 'feature' only makes it more complex.


  parent reply	other threads:[~2012-09-05 10:20 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 14:18 [RFC 0/5] forced comounts for cgroups Glauber Costa
2012-09-04 14:18 ` Glauber Costa
2012-09-04 14:18 ` [RFC 1/5] cgroup: allow some comounts to be forced Glauber Costa
2012-09-04 14:18   ` Glauber Costa
2012-09-04 14:18 ` [RFC 2/5] sched: adjust exec_clock to use it as cpu usage metric Glauber Costa
2012-09-04 14:18   ` Glauber Costa
2012-09-04 14:18 ` [RFC 3/5] sched: do not call cpuacct_charge when cpu and cpuacct are comounted Glauber Costa
2012-09-04 14:18   ` Glauber Costa
2012-09-04 14:18 ` [RFC 4/5] cpuacct: do not gather cpuacct statistics when not mounted Glauber Costa
2012-09-04 14:18   ` Glauber Costa
2012-09-04 14:18 ` [RFC 5/5] sched: add cpusets to comounts list Glauber Costa
2012-09-04 14:18   ` Glauber Costa
     [not found] ` <1346768300-10282-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 21:46   ` [RFC 0/5] forced comounts for cgroups Tejun Heo
2012-09-04 21:46     ` Tejun Heo
2012-09-04 21:46     ` Tejun Heo
     [not found]     ` <20120904214602.GA9092-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-09-05  8:03       ` Glauber Costa
2012-09-05  8:03         ` Glauber Costa
2012-09-05  8:03         ` Glauber Costa
2012-09-05  8:14         ` Tejun Heo
2012-09-05  8:14           ` Tejun Heo
2012-09-05  8:17           ` Glauber Costa
2012-09-05  8:17             ` Glauber Costa
2012-09-05  8:29             ` Tejun Heo
2012-09-05  8:29               ` Tejun Heo
     [not found]               ` <20120905082947.GD3195-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-09-05  8:35                 ` Glauber Costa
2012-09-05  8:35                   ` Glauber Costa
2012-09-05  8:35                   ` Glauber Costa
2012-09-05  8:47                   ` Tejun Heo
2012-09-05  8:47                     ` Tejun Heo
     [not found]                     ` <20120905084740.GE3195-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-09-05  8:55                       ` Glauber Costa
2012-09-05  8:55                         ` Glauber Costa
2012-09-05  8:55                         ` Glauber Costa
2012-09-05  9:07                         ` Tejun Heo
2012-09-05  9:07                           ` Tejun Heo
     [not found]                           ` <20120905090744.GG3195-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-09-05  9:06                             ` Glauber Costa
2012-09-05  9:06                               ` Glauber Costa
2012-09-05  9:06                               ` Glauber Costa
     [not found]                               ` <5047161F.60503-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-05  9:14                                 ` Tejun Heo
2012-09-05  9:14                                   ` Tejun Heo
2012-09-05  9:14                                   ` Tejun Heo
2012-09-05  9:06                     ` Peter Zijlstra
2012-09-05  9:06                       ` Peter Zijlstra
2012-09-05  9:07                       ` Peter Zijlstra
2012-09-05  9:07                         ` Peter Zijlstra
2012-09-05  9:22                         ` Tejun Heo
2012-09-05  9:22                           ` Tejun Heo
2012-09-05  9:11                       ` Tejun Heo
2012-09-05  9:11                         ` Tejun Heo
2012-09-05  9:11                         ` Tejun Heo
2012-09-05  9:12                         ` Glauber Costa
2012-09-05  9:12                           ` Glauber Costa
     [not found]                           ` <50471782.6060800-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-05  9:19                             ` Tejun Heo
2012-09-05  9:19                               ` Tejun Heo
2012-09-05  9:19                               ` Tejun Heo
2012-09-05  9:30                               ` Glauber Costa
2012-09-05  9:30                                 ` Glauber Costa
2012-09-05  9:30                                 ` Glauber Costa
2012-09-05  9:26                           ` Peter Zijlstra
2012-09-05  9:26                             ` Peter Zijlstra
2012-09-05  9:31                             ` Glauber Costa
2012-09-05  9:31                               ` Glauber Costa
2012-09-05  9:31                               ` Glauber Costa
2012-09-05  9:45                               ` Tejun Heo
2012-09-05  9:45                                 ` Tejun Heo
2012-09-05  9:48                                 ` Glauber Costa
2012-09-05  9:48                                   ` Glauber Costa
2012-09-05  9:56                                   ` Tejun Heo
2012-09-05  9:56                                     ` Tejun Heo
     [not found]                               ` <50471C0C.7050600-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-05 10:20                                 ` Peter Zijlstra [this message]
2012-09-05 10:20                                   ` Peter Zijlstra
2012-09-05 10:20                                   ` Peter Zijlstra
2012-09-06 20:38                                   ` Tejun Heo
2012-09-06 20:38                                     ` Tejun Heo
     [not found]                                     ` <20120906203839.GM29092-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-06 22:39                                       ` Glauber Costa
2012-09-06 22:39                                         ` Glauber Costa
2012-09-06 22:39                                         ` Glauber Costa
     [not found]                                         ` <50492617.8030609-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-06 22:45                                           ` Tejun Heo
2012-09-06 22:45                                             ` Tejun Heo
2012-09-06 22:45                                             ` Tejun Heo
2012-09-05  9:32                       ` Tejun Heo
2012-09-05  9:32                         ` Tejun Heo
2012-09-05  9:32                         ` Tejun Heo
2012-09-05 10:04                         ` Peter Zijlstra
2012-09-05 10:04                           ` Peter Zijlstra
2012-09-06 20:46                           ` Tejun Heo
2012-09-06 20:46                             ` Tejun Heo
2012-09-06 21:11                             ` Paul Turner
2012-09-06 21:11                               ` Paul Turner
2012-09-06 22:36                               ` Glauber Costa
2012-09-06 22:36                                 ` Glauber Costa
2012-09-08 13:36                               ` Dhaval Giani
2012-09-08 13:36                                 ` Dhaval Giani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346840453.2461.6.camel@laptop \
    --to=a.p.zijlstra-/nlkjasks4vmr6xm/wnwpw@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    --cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
    --cc=lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.