* [PATCH] hob/imagedetailspage: "Image ready" icon appers only after the image was generated
@ 2012-09-03 11:22 Cristiana Voicu
2012-09-07 11:03 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Cristiana Voicu @ 2012-09-03 11:22 UTC (permalink / raw)
To: bitbake-devel
Now, "Your image is ready" icon doesn't appear when you come back on Imagedetails
page. It appears only after the image was generated.
[YOCTO #2984]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
index 40eb7a4..ea26ba3 100755
--- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
@@ -183,7 +183,7 @@ class ImageDetailsPage (HobPage):
self.pack_start(self.group_align, expand=True, fill=True)
self.build_result = None
- if self.build_succeeded:
+ if self.build_succeeded and self.builder.current_step == self.builder.IMAGE_GENERATING:
# building is the previous step
icon = gtk.Image()
pixmap_path = hic.ICON_INDI_CONFIRM_FILE
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hob/imagedetailspage: "Image ready" icon appers only after the image was generated
2012-09-03 11:22 [PATCH] hob/imagedetailspage: "Image ready" icon appers only after the image was generated Cristiana Voicu
@ 2012-09-07 11:03 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-09-07 11:03 UTC (permalink / raw)
To: Cristiana Voicu; +Cc: bitbake-devel
On Mon, 2012-09-03 at 14:22 +0300, Cristiana Voicu wrote:
> Now, "Your image is ready" icon doesn't appear when you come back on Imagedetails
> page. It appears only after the image was generated.
>
> [YOCTO #2984]
>
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
> bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-07 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-03 11:22 [PATCH] hob/imagedetailspage: "Image ready" icon appers only after the image was generated Cristiana Voicu
2012-09-07 11:03 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.