regulator: fan53555: vsel_max does not match with the max voltage?

regulator: fan53555: vsel_max does not match with the max voltage?

[Axel Lin]

Hi Yunfan,
Just found below issue while reading the code:

For FAN53555_CHIP_ID_04,
        di->vsel_min = 603000;
        di->vsel_max = 1411000;
        di->vsel_step = 12826;

So we have below voltage list for FAN53555_CHIP_ID_04:

volt[0] = 603000
volt[1] = 615826
volt[2] = 628652
volt[3] = 641478
volt[4] = 654304
volt[5] = 667130

.......

volt[60] = 1372560
volt[61] = 1385386
volt[62] = 1398212
volt[63] = 1411038

Then volt[63] is greater than the vsel_max now.
This looks does not make sense.

Regards,
Axel

RE: regulator: fan53555: vsel_max does not match with the max voltage?

[Yunfan Zhang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 952 bytes --]

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@gmail.com]
> Sent: 2012年9月10日 11:05
> To: Yunfan Zhang
> Cc: Liam Girdwood; Mark Brown; linux-kernel@vger.kernel.org
> Subject: regulator: fan53555: vsel_max does not match with the max voltage?
> 
> Hi Yunfan,
> Just found below issue while reading the code:
> 
> For FAN53555_CHIP_ID_04,
>         di->vsel_min = 603000;
>         di->vsel_max = 1411000;
>         di->vsel_step = 12826;
> volt[63] = 1411038
> 
> Then volt[63] is greater than the vsel_max now.
> This looks does not make sense.

Axel, Thanks for your findings! 
Yes, the volt[63] is GT the vsel_max. Actually vsel_max is not used... The max voltage will be bounded by desc->n_voltages. I will make a patch to remove it to avoid confusing. Thanks a lot!
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥