From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Fengguang Wu <fengguang.wu@intel.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined
Date: Mon, 10 Sep 2012 05:18:31 +0000 [thread overview]
Message-ID: <1347254311.11820.0.camel@pasglop> (raw)
In-Reply-To: <20120910025121.GB1572@shangw.(null)>
On Mon, 2012-09-10 at 10:51 +0800, Gavin Shan wrote:
> >
>
> The global functions eeh_pe_get() and eeh_pe_get_parent() will be used
> by subsequent patches. I think ppc/next merged 23 patches for EEH core
> this time. I'm not sure I should refactor those patches to avoid the
> build failure? :-)
No, don't bother, it's a case where gcc warnings are a bit too zealous.
Next time we'll try to avoid it but for now, I won't rebase.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Fengguang Wu <fengguang.wu@intel.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used
Date: Mon, 10 Sep 2012 15:18:31 +1000 [thread overview]
Message-ID: <1347254311.11820.0.camel@pasglop> (raw)
In-Reply-To: <20120910025121.GB1572@shangw.(null)>
On Mon, 2012-09-10 at 10:51 +0800, Gavin Shan wrote:
> >
>
> The global functions eeh_pe_get() and eeh_pe_get_parent() will be used
> by subsequent patches. I think ppc/next merged 23 patches for EEH core
> this time. I'm not sure I should refactor those patches to avoid the
> build failure? :-)
No, don't bother, it's a case where gcc warnings are a bit too zealous.
Next time we'll try to avoid it but for now, I won't rebase.
Cheers,
Ben.
next prev parent reply other threads:[~2012-09-10 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 2:34 [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but Fengguang Wu
2012-09-10 2:34 ` [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used Fengguang Wu
2012-09-10 2:51 ` Gavin Shan
2012-09-10 2:56 ` [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined Fengguang Wu
2012-09-10 2:56 ` [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used Fengguang Wu
2012-09-10 5:18 ` Benjamin Herrenschmidt [this message]
2012-09-10 5:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347254311.11820.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.