From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>, lrg <lrg@ti.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH] ASoC: codecs: Add DA9055 codec driver
Date: Thu, 13 Sep 2012 17:38:36 +0530 [thread overview]
Message-ID: <1347538116.16763.6.camel@matrix> (raw)
In-Reply-To: <20120912025709.GD9162@opensource.wolfsonmicro.com>
On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote:
>
> > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN);
>
> DAPM.
Here the trouble in making it DAPM based is that there is no separate
control for AIF input and output. It is confirmed that AIF_EN is the
master control bit, which enables both output as well as input. The AIF
_OE bit is redundant. If we use the same control bit(i.e AIF_EN) for
both DAPM_AIF_IN and DAPM_AIF_OUT, there will be obvious side effects.
Is there any other way to take care of this? Or should we leave it
outside DAPM?
WARNING: multiple messages have this Message-ID (diff)
From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver
Date: Thu, 13 Sep 2012 17:38:36 +0530 [thread overview]
Message-ID: <1347538116.16763.6.camel@matrix> (raw)
In-Reply-To: <20120912025709.GD9162@opensource.wolfsonmicro.com>
On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote:
>
> > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN);
>
> DAPM.
Here the trouble in making it DAPM based is that there is no separate
control for AIF input and output. It is confirmed that AIF_EN is the
master control bit, which enables both output as well as input. The AIF
_OE bit is redundant. If we use the same control bit(i.e AIF_EN) for
both DAPM_AIF_IN and DAPM_AIF_OUT, there will be obvious side effects.
Is there any other way to take care of this? Or should we leave it
outside DAPM?
next prev parent reply other threads:[~2012-09-13 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:03 [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver Ashish Chavan
2012-09-12 2:57 ` Mark Brown
2012-09-12 12:56 ` Ashish Chavan
2012-09-12 12:56 ` [alsa-devel] " Ashish Chavan
2012-09-12 12:49 ` Mark Brown
2012-09-12 12:49 ` [alsa-devel] " Mark Brown
2012-09-12 13:40 ` Ashish P. Chavan
2012-09-12 13:40 ` [alsa-devel] " Ashish P. Chavan
2012-09-13 12:08 ` Ashish Chavan [this message]
2012-09-13 12:08 ` Ashish Chavan
2012-09-13 12:03 ` Mark Brown
2012-09-13 12:03 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347538116.16763.6.camel@matrix \
--to=ashish.chavan@kpitcummins.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.