diff for duplicates of <1348488182.2530.13.camel@hornet> diff --git a/a/1.txt b/N1/1.txt index 92609d5..3e2816d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,33 +1,43 @@ -T24gRnJpLCAyMDEyLTA5LTIxIGF0IDE5OjE4ICswMTAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+ -IE9uIEZyaSwgU2VwIDIxLCAyMDEyIGF0IDA1OjU2OjMxUE0gKzAxMDAsIFBhd2VsIE1vbGwgd3Jv -dGU6Cj4gPiBGcm9tOiBQYXdlbCBNb2xsIDxwYXdlbC5tb2xsQGFybS5jb20+Cj4gPiAKPiA+IGh3 -bW9uIGZyYW1ld29yayBkcml2ZXIgZm9yIFZlcnNhdGlsZSBFeHByZXNzIHNlbnNvcnMsIHByb3Zp -ZGluZwo+ID4gaW5mb3JtYXRpb24gYWJvdXQgYm9hcmQgbGV2ZWwgdm9sdGFnZSAob25seSB3aGVu -IHJlZ3VsYXRvciBkcml2ZXIKPiA+IGlzIG5vdCBjb25maWd1cmVkKSwgY3VycmVudHMsIHRlbXBl -cmF0dXJlIGFuZCBwb3dlci9lbmVyZ3kgdXNhZ2UuCj4gPiBMYWJlbHMgZm9yIHRoZSB2YWx1ZXMg -Y2FuIGJlIGRlZmluZWQgYXMgRFQgcHJvcGVydGllcy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog -UGF3ZWwgTW9sbCA8cGF3ZWwubW9sbEBhcm0uY29tPgo+ID4gLS0tCj4gPiAgLi4uL2RldmljZXRy -ZWUvYmluZGluZ3MvaHdtb24vdmV4cHJlc3MudHh0ICAgICAgICAgfCAgIDIzICsrCj4gPiAgRG9j -dW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDM0ICsr -Kwo+ID4gIGRyaXZlcnMvaHdtb24vS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg -IHwgICAgOCArCj4gPiAgZHJpdmVycy9od21vbi9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAg -ICAgICAgICAgfCAgICAxICsKPiA+ICBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMgICAgICAgICAg -ICAgICAgICAgICAgICAgICB8ICAyMjkgKysrKysrKysrKysrKysrKysrKysKPiA+ICA1IGZpbGVz -IGNoYW5nZWQsIDI5NSBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3Vt -ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9od21vbi92ZXhwcmVzcy50eHQKPiA+ICBjcmVh -dGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcwo+ID4gIGNyZWF0ZSBt -b2RlIDEwMDY0NCBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMKPiA+IAo+IFsgLi4uIF0KPiAKPiA+ -ICsKPiA+ICsJZXJyID0gc3lzZnNfY3JlYXRlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgbWF0Y2gt -PmRhdGEpOwo+ID4gKwlpZiAoZXJyKQo+ID4gKwkJZ290byBlcnJvcjsKPiAKPiBZb3UnbGwgbmVl -ZCBhIHNlY29uZCBsYWJlbCBmb3IgdGhhdC4gU2luY2UgdGhlIGdyb3VwIHdhcyBub3QgY3JlYXRl -ZCwgeW91IGNhbgo+IG5vdCBkZWxldGUgaXQuCgpBY3R1YWxseSBJIHRoaW5rIEkgY2FuLi4uIFRo -ZSBzeXNmc19yZW1vdmVfZ3JvdXAoKSBlZmZlY3RpdmVseSBpcyBhCndyYXBwZXIgZm9yIHN5c2Zz -X2hhc2hfYW5kX3JlbW92ZSgpIHdoaWNoIGFjdHMgbGlrZSAicm0gLWYiIC0gZG9lcwpub3RoaW5n -IGlmIHRoZSBmaWxlIGRvZXNuJ3QgZXhpc3QuIEV2ZW4gZHJpdmVycy9od21vbi9sbTgzLmMgKHdo -aWNoLCBieQpwdXJlIGNvaW5jaWRlbmNlLCBJIHdhcyBsb29raW5nIGF0IHdoZW4gcmUtd29ya2lu -ZyB0aGlzIGRyaXZlcikgZG9lcwp0aGF0IGluIGV4aXRfcmVtb3ZlX2ZpbGVzLi4uCgpBbnl3YXks -IGl0J3Mgbm90aGluZyB0byBhcmd1ZSBhYm91dCwgc28gSSdsbCBjaGFuZ2UgaXQgYW5kIHNlbmQK -KGhvcGVmdWxseSA7LSkgZmluYWwgdmVyc2lvbiBpbiBhIGppZmZ5LgoKVGhhbmtzIQoKUGF3ZcWC -CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNl -bnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3Rz -LmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= +On Fri, 2012-09-21 at 19:18 +0100, Guenter Roeck wrote: +> On Fri, Sep 21, 2012 at 05:56:31PM +0100, Pawel Moll wrote: +> > From: Pawel Moll <pawel.moll@arm.com> +> > +> > hwmon framework driver for Versatile Express sensors, providing +> > information about board level voltage (only when regulator driver +> > is not configured), currents, temperature and power/energy usage. +> > Labels for the values can be defined as DT properties. +> > +> > Signed-off-by: Pawel Moll <pawel.moll@arm.com> +> > --- +> > .../devicetree/bindings/hwmon/vexpress.txt | 23 ++ +> > Documentation/hwmon/vexpress | 34 +++ +> > drivers/hwmon/Kconfig | 8 + +> > drivers/hwmon/Makefile | 1 + +> > drivers/hwmon/vexpress.c | 229 ++++++++++++++++++++ +> > 5 files changed, 295 insertions(+) +> > create mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt +> > create mode 100644 Documentation/hwmon/vexpress +> > create mode 100644 drivers/hwmon/vexpress.c +> > +> [ ... ] +> +> > + +> > + err = sysfs_create_group(&pdev->dev.kobj, match->data); +> > + if (err) +> > + goto error; +> +> You'll need a second label for that. Since the group was not created, you can +> not delete it. + +Actually I think I can... The sysfs_remove_group() effectively is a +wrapper for sysfs_hash_and_remove() which acts like "rm -f" - does +nothing if the file doesn't exist. Even drivers/hwmon/lm83.c (which, by +pure coincidence, I was looking at when re-working this driver) does +that in exit_remove_files... + +Anyway, it's nothing to argue about, so I'll change it and send +(hopefully ;-) final version in a jiffy. + +Thanks! + +Pawe? diff --git a/a/content_digest b/N1/content_digest index efd4610..6d8e4dc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,43 +1,53 @@ "ref\01348246591-2409-1-git-send-email-mail@pawelmoll.com\0" "ref\020120921181844.GA20763@roeck-us.net\0" - "From\0Pawel Moll <pawel.moll@arm.com>\0" - "Subject\0Re: [lm-sensors] [PATCH v4] hwmon: Versatile Express hwmon driver\0" - "Date\0Mon, 24 Sep 2012 12:03:02 +0000\0" + "From\0pawel.moll@arm.com (Pawel Moll)\0" + "Subject\0[PATCH v4] hwmon: Versatile Express hwmon driver\0" + "Date\0Mon, 24 Sep 2012 13:03:02 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDEyLTA5LTIxIGF0IDE5OjE4ICswMTAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+\n" - "IE9uIEZyaSwgU2VwIDIxLCAyMDEyIGF0IDA1OjU2OjMxUE0gKzAxMDAsIFBhd2VsIE1vbGwgd3Jv\n" - "dGU6Cj4gPiBGcm9tOiBQYXdlbCBNb2xsIDxwYXdlbC5tb2xsQGFybS5jb20+Cj4gPiAKPiA+IGh3\n" - "bW9uIGZyYW1ld29yayBkcml2ZXIgZm9yIFZlcnNhdGlsZSBFeHByZXNzIHNlbnNvcnMsIHByb3Zp\n" - "ZGluZwo+ID4gaW5mb3JtYXRpb24gYWJvdXQgYm9hcmQgbGV2ZWwgdm9sdGFnZSAob25seSB3aGVu\n" - "IHJlZ3VsYXRvciBkcml2ZXIKPiA+IGlzIG5vdCBjb25maWd1cmVkKSwgY3VycmVudHMsIHRlbXBl\n" - "cmF0dXJlIGFuZCBwb3dlci9lbmVyZ3kgdXNhZ2UuCj4gPiBMYWJlbHMgZm9yIHRoZSB2YWx1ZXMg\n" - "Y2FuIGJlIGRlZmluZWQgYXMgRFQgcHJvcGVydGllcy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog\n" - "UGF3ZWwgTW9sbCA8cGF3ZWwubW9sbEBhcm0uY29tPgo+ID4gLS0tCj4gPiAgLi4uL2RldmljZXRy\n" - "ZWUvYmluZGluZ3MvaHdtb24vdmV4cHJlc3MudHh0ICAgICAgICAgfCAgIDIzICsrCj4gPiAgRG9j\n" - "dW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDM0ICsr\n" - "Kwo+ID4gIGRyaXZlcnMvaHdtb24vS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg\n" - "IHwgICAgOCArCj4gPiAgZHJpdmVycy9od21vbi9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAg\n" - "ICAgICAgICAgfCAgICAxICsKPiA+ICBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMgICAgICAgICAg\n" - "ICAgICAgICAgICAgICAgICB8ICAyMjkgKysrKysrKysrKysrKysrKysrKysKPiA+ICA1IGZpbGVz\n" - "IGNoYW5nZWQsIDI5NSBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3Vt\n" - "ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9od21vbi92ZXhwcmVzcy50eHQKPiA+ICBjcmVh\n" - "dGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcwo+ID4gIGNyZWF0ZSBt\n" - "b2RlIDEwMDY0NCBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMKPiA+IAo+IFsgLi4uIF0KPiAKPiA+\n" - "ICsKPiA+ICsJZXJyID0gc3lzZnNfY3JlYXRlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgbWF0Y2gt\n" - "PmRhdGEpOwo+ID4gKwlpZiAoZXJyKQo+ID4gKwkJZ290byBlcnJvcjsKPiAKPiBZb3UnbGwgbmVl\n" - "ZCBhIHNlY29uZCBsYWJlbCBmb3IgdGhhdC4gU2luY2UgdGhlIGdyb3VwIHdhcyBub3QgY3JlYXRl\n" - "ZCwgeW91IGNhbgo+IG5vdCBkZWxldGUgaXQuCgpBY3R1YWxseSBJIHRoaW5rIEkgY2FuLi4uIFRo\n" - "ZSBzeXNmc19yZW1vdmVfZ3JvdXAoKSBlZmZlY3RpdmVseSBpcyBhCndyYXBwZXIgZm9yIHN5c2Zz\n" - "X2hhc2hfYW5kX3JlbW92ZSgpIHdoaWNoIGFjdHMgbGlrZSAicm0gLWYiIC0gZG9lcwpub3RoaW5n\n" - "IGlmIHRoZSBmaWxlIGRvZXNuJ3QgZXhpc3QuIEV2ZW4gZHJpdmVycy9od21vbi9sbTgzLmMgKHdo\n" - "aWNoLCBieQpwdXJlIGNvaW5jaWRlbmNlLCBJIHdhcyBsb29raW5nIGF0IHdoZW4gcmUtd29ya2lu\n" - "ZyB0aGlzIGRyaXZlcikgZG9lcwp0aGF0IGluIGV4aXRfcmVtb3ZlX2ZpbGVzLi4uCgpBbnl3YXks\n" - "IGl0J3Mgbm90aGluZyB0byBhcmd1ZSBhYm91dCwgc28gSSdsbCBjaGFuZ2UgaXQgYW5kIHNlbmQK\n" - "KGhvcGVmdWxseSA7LSkgZmluYWwgdmVyc2lvbiBpbiBhIGppZmZ5LgoKVGhhbmtzIQoKUGF3ZcWC\n" - "CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNl\n" - "bnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3Rz\n" - LmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= + "On Fri, 2012-09-21 at 19:18 +0100, Guenter Roeck wrote:\n" + "> On Fri, Sep 21, 2012 at 05:56:31PM +0100, Pawel Moll wrote:\n" + "> > From: Pawel Moll <pawel.moll@arm.com>\n" + "> > \n" + "> > hwmon framework driver for Versatile Express sensors, providing\n" + "> > information about board level voltage (only when regulator driver\n" + "> > is not configured), currents, temperature and power/energy usage.\n" + "> > Labels for the values can be defined as DT properties.\n" + "> > \n" + "> > Signed-off-by: Pawel Moll <pawel.moll@arm.com>\n" + "> > ---\n" + "> > .../devicetree/bindings/hwmon/vexpress.txt | 23 ++\n" + "> > Documentation/hwmon/vexpress | 34 +++\n" + "> > drivers/hwmon/Kconfig | 8 +\n" + "> > drivers/hwmon/Makefile | 1 +\n" + "> > drivers/hwmon/vexpress.c | 229 ++++++++++++++++++++\n" + "> > 5 files changed, 295 insertions(+)\n" + "> > create mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt\n" + "> > create mode 100644 Documentation/hwmon/vexpress\n" + "> > create mode 100644 drivers/hwmon/vexpress.c\n" + "> > \n" + "> [ ... ]\n" + "> \n" + "> > +\n" + "> > +\terr = sysfs_create_group(&pdev->dev.kobj, match->data);\n" + "> > +\tif (err)\n" + "> > +\t\tgoto error;\n" + "> \n" + "> You'll need a second label for that. Since the group was not created, you can\n" + "> not delete it.\n" + "\n" + "Actually I think I can... The sysfs_remove_group() effectively is a\n" + "wrapper for sysfs_hash_and_remove() which acts like \"rm -f\" - does\n" + "nothing if the file doesn't exist. Even drivers/hwmon/lm83.c (which, by\n" + "pure coincidence, I was looking at when re-working this driver) does\n" + "that in exit_remove_files...\n" + "\n" + "Anyway, it's nothing to argue about, so I'll change it and send\n" + "(hopefully ;-) final version in a jiffy.\n" + "\n" + "Thanks!\n" + "\n" + Pawe? -3ed3247eb9a1362da3ad5e795ae6104313dc0fb5bd19f53cd7ec281b475d1a07 +c9c3379fe7c801fa96f0a208995144c17af3f41f0c2013480a26f5fafa96ecd3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.