From: Pawel Moll <pawel.moll@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH v4] hwmon: Versatile Express hwmon driver
Date: Mon, 24 Sep 2012 12:03:02 +0000 [thread overview]
Message-ID: <1348488182.2530.13.camel@hornet> (raw)
In-Reply-To: <20120921181844.GA20763@roeck-us.net>
T24gRnJpLCAyMDEyLTA5LTIxIGF0IDE5OjE4ICswMTAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+
IE9uIEZyaSwgU2VwIDIxLCAyMDEyIGF0IDA1OjU2OjMxUE0gKzAxMDAsIFBhd2VsIE1vbGwgd3Jv
dGU6Cj4gPiBGcm9tOiBQYXdlbCBNb2xsIDxwYXdlbC5tb2xsQGFybS5jb20+Cj4gPiAKPiA+IGh3
bW9uIGZyYW1ld29yayBkcml2ZXIgZm9yIFZlcnNhdGlsZSBFeHByZXNzIHNlbnNvcnMsIHByb3Zp
ZGluZwo+ID4gaW5mb3JtYXRpb24gYWJvdXQgYm9hcmQgbGV2ZWwgdm9sdGFnZSAob25seSB3aGVu
IHJlZ3VsYXRvciBkcml2ZXIKPiA+IGlzIG5vdCBjb25maWd1cmVkKSwgY3VycmVudHMsIHRlbXBl
cmF0dXJlIGFuZCBwb3dlci9lbmVyZ3kgdXNhZ2UuCj4gPiBMYWJlbHMgZm9yIHRoZSB2YWx1ZXMg
Y2FuIGJlIGRlZmluZWQgYXMgRFQgcHJvcGVydGllcy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog
UGF3ZWwgTW9sbCA8cGF3ZWwubW9sbEBhcm0uY29tPgo+ID4gLS0tCj4gPiAgLi4uL2RldmljZXRy
ZWUvYmluZGluZ3MvaHdtb24vdmV4cHJlc3MudHh0ICAgICAgICAgfCAgIDIzICsrCj4gPiAgRG9j
dW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDM0ICsr
Kwo+ID4gIGRyaXZlcnMvaHdtb24vS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwgICAgOCArCj4gPiAgZHJpdmVycy9od21vbi9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgfCAgICAxICsKPiA+ICBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAyMjkgKysrKysrKysrKysrKysrKysrKysKPiA+ICA1IGZpbGVz
IGNoYW5nZWQsIDI5NSBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3Vt
ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9od21vbi92ZXhwcmVzcy50eHQKPiA+ICBjcmVh
dGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9od21vbi92ZXhwcmVzcwo+ID4gIGNyZWF0ZSBt
b2RlIDEwMDY0NCBkcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMKPiA+IAo+IFsgLi4uIF0KPiAKPiA+
ICsKPiA+ICsJZXJyID0gc3lzZnNfY3JlYXRlX2dyb3VwKCZwZGV2LT5kZXYua29iaiwgbWF0Y2gt
PmRhdGEpOwo+ID4gKwlpZiAoZXJyKQo+ID4gKwkJZ290byBlcnJvcjsKPiAKPiBZb3UnbGwgbmVl
ZCBhIHNlY29uZCBsYWJlbCBmb3IgdGhhdC4gU2luY2UgdGhlIGdyb3VwIHdhcyBub3QgY3JlYXRl
ZCwgeW91IGNhbgo+IG5vdCBkZWxldGUgaXQuCgpBY3R1YWxseSBJIHRoaW5rIEkgY2FuLi4uIFRo
ZSBzeXNmc19yZW1vdmVfZ3JvdXAoKSBlZmZlY3RpdmVseSBpcyBhCndyYXBwZXIgZm9yIHN5c2Zz
X2hhc2hfYW5kX3JlbW92ZSgpIHdoaWNoIGFjdHMgbGlrZSAicm0gLWYiIC0gZG9lcwpub3RoaW5n
IGlmIHRoZSBmaWxlIGRvZXNuJ3QgZXhpc3QuIEV2ZW4gZHJpdmVycy9od21vbi9sbTgzLmMgKHdo
aWNoLCBieQpwdXJlIGNvaW5jaWRlbmNlLCBJIHdhcyBsb29raW5nIGF0IHdoZW4gcmUtd29ya2lu
ZyB0aGlzIGRyaXZlcikgZG9lcwp0aGF0IGluIGV4aXRfcmVtb3ZlX2ZpbGVzLi4uCgpBbnl3YXks
IGl0J3Mgbm90aGluZyB0byBhcmd1ZSBhYm91dCwgc28gSSdsbCBjaGFuZ2UgaXQgYW5kIHNlbmQK
KGhvcGVmdWxseSA7LSkgZmluYWwgdmVyc2lvbiBpbiBhIGppZmZ5LgoKVGhhbmtzIQoKUGF3ZcWC
CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNl
bnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3Rz
LmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=
WARNING: multiple messages have this Message-ID (diff)
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] hwmon: Versatile Express hwmon driver
Date: Mon, 24 Sep 2012 13:03:02 +0100 [thread overview]
Message-ID: <1348488182.2530.13.camel@hornet> (raw)
In-Reply-To: <20120921181844.GA20763@roeck-us.net>
On Fri, 2012-09-21 at 19:18 +0100, Guenter Roeck wrote:
> On Fri, Sep 21, 2012 at 05:56:31PM +0100, Pawel Moll wrote:
> > From: Pawel Moll <pawel.moll@arm.com>
> >
> > hwmon framework driver for Versatile Express sensors, providing
> > information about board level voltage (only when regulator driver
> > is not configured), currents, temperature and power/energy usage.
> > Labels for the values can be defined as DT properties.
> >
> > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> > ---
> > .../devicetree/bindings/hwmon/vexpress.txt | 23 ++
> > Documentation/hwmon/vexpress | 34 +++
> > drivers/hwmon/Kconfig | 8 +
> > drivers/hwmon/Makefile | 1 +
> > drivers/hwmon/vexpress.c | 229 ++++++++++++++++++++
> > 5 files changed, 295 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/vexpress.txt
> > create mode 100644 Documentation/hwmon/vexpress
> > create mode 100644 drivers/hwmon/vexpress.c
> >
> [ ... ]
>
> > +
> > + err = sysfs_create_group(&pdev->dev.kobj, match->data);
> > + if (err)
> > + goto error;
>
> You'll need a second label for that. Since the group was not created, you can
> not delete it.
Actually I think I can... The sysfs_remove_group() effectively is a
wrapper for sysfs_hash_and_remove() which acts like "rm -f" - does
nothing if the file doesn't exist. Even drivers/hwmon/lm83.c (which, by
pure coincidence, I was looking at when re-working this driver) does
that in exit_remove_files...
Anyway, it's nothing to argue about, so I'll change it and send
(hopefully ;-) final version in a jiffy.
Thanks!
Pawe?
next prev parent reply other threads:[~2012-09-24 12:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 16:56 [lm-sensors] [PATCH v4] hwmon: Versatile Express hwmon driver Pawel Moll
2012-09-21 16:56 ` Pawel Moll
2012-09-21 18:18 ` [lm-sensors] " Guenter Roeck
2012-09-21 18:18 ` Guenter Roeck
2012-09-24 12:03 ` Pawel Moll [this message]
2012-09-24 12:03 ` Pawel Moll
2012-09-24 12:08 ` [lm-sensors] " Jean Delvare
2012-09-24 12:08 ` Jean Delvare
2012-09-24 12:28 ` [lm-sensors] " Guenter Roeck
2012-09-24 12:28 ` Guenter Roeck
2012-09-24 15:59 ` [lm-sensors] " Guenter Roeck
2012-09-24 15:59 ` Guenter Roeck
2012-09-24 16:09 ` [lm-sensors] " Pawel Moll
2012-09-24 16:09 ` Pawel Moll
2012-09-24 17:18 ` [lm-sensors] " Guenter Roeck
2012-09-24 17:18 ` Guenter Roeck
2012-09-24 17:24 ` [lm-sensors] " Pawel Moll
2012-09-24 17:24 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348488182.2530.13.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.