All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] hob/builddetailspage: change branch field
@ 2012-09-26 13:11 Cristiana Voicu
  2012-09-27 15:43 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Cristiana Voicu @ 2012-09-26 13:11 UTC (permalink / raw)
  To: bitbake-devel

When a user makes a build from a tarball, it shows fatal error in branch field.
Now it not complains as a fatal error. It is a normal message.

[YOCTO #3114]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/builddetailspage.py |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/bitbake/lib/bb/ui/crumbs/builddetailspage.py b/bitbake/lib/bb/ui/crumbs/builddetailspage.py
index a927c21..65b421c 100755
--- a/bitbake/lib/bb/ui/crumbs/builddetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/builddetailspage.py
@@ -99,6 +99,8 @@ class BuildConfigurationTreeView(gtk.TreeView):
             import os, os.path
             if os.path.exists(path):
                 branch = bb.process.run('cd %s; git branch | grep "^* " | tr -d "* "' % path)[0]
+                if branch.startswith("fatal:"):
+                    branch = "(unknown)"
                 if branch:
                     branch = branch.strip('\n')
                     vars.append(self.set_vars("Branch:", branch))
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] hob/builddetailspage: change branch field
  2012-09-26 13:11 [PATCH v2] hob/builddetailspage: change branch field Cristiana Voicu
@ 2012-09-27 15:43 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-09-27 15:43 UTC (permalink / raw)
  To: Cristiana Voicu; +Cc: bitbake-devel

On Wed, 2012-09-26 at 16:11 +0300, Cristiana Voicu wrote:
> When a user makes a build from a tarball, it shows fatal error in branch field.
> Now it not complains as a fatal error. It is a normal message.
> 
> [YOCTO #3114]
> 
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/builddetailspage.py |    2 ++
>  1 file changed, 2 insertions(+)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-27 15:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 13:11 [PATCH v2] hob/builddetailspage: change branch field Cristiana Voicu
2012-09-27 15:43 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.