From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: Tony Lindgren <tony@atomide.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
Sven Krauss <sven.krauss@web.de>
Subject: Re: [PATCH] mtd: omap2-nand: avoid unaligned DMA accesses, fall back on prefetch method
Date: Fri, 28 Sep 2012 06:35:45 +0300 [thread overview]
Message-ID: <1348803345.1830.2.camel@kyv> (raw)
In-Reply-To: <1348155850-26174-1-git-send-email-arnout@mind.be>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Thu, 2012-09-20 at 17:44 +0200, Arnout Vandecappelle (Essensium/Mind)
wrote:
> It's difficult to reproduce the error, because the buffers are
> aligned most of the time.
Can you just take one of the mtd tests (e.g., mtd_speedtest), amend it a
little and make sure it uses unaligned buffers?
> Perhaps a better method is to fetch the first few unaligned bytes
> with the prefetch method, and then continue with DMA. However,
> since it's hard to force an unaligned buffer, it's also hard to
> test that this method works.
Yes, this would be a lot cleaner.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Tony Lindgren <tony@atomide.com>,
Sven Krauss <sven.krauss@web.de>
Subject: Re: [PATCH] mtd: omap2-nand: avoid unaligned DMA accesses, fall back on prefetch method
Date: Fri, 28 Sep 2012 06:35:45 +0300 [thread overview]
Message-ID: <1348803345.1830.2.camel@kyv> (raw)
In-Reply-To: <1348155850-26174-1-git-send-email-arnout@mind.be>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Thu, 2012-09-20 at 17:44 +0200, Arnout Vandecappelle (Essensium/Mind)
wrote:
> It's difficult to reproduce the error, because the buffers are
> aligned most of the time.
Can you just take one of the mtd tests (e.g., mtd_speedtest), amend it a
little and make sure it uses unaligned buffers?
> Perhaps a better method is to fetch the first few unaligned bytes
> with the prefetch method, and then continue with DMA. However,
> since it's hard to force an unaligned buffer, it's also hard to
> test that this method works.
Yes, this would be a lot cleaner.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-28 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 15:44 [PATCH] mtd: omap2-nand: avoid unaligned DMA accesses, fall back on prefetch method Arnout Vandecappelle (Essensium/Mind)
2012-09-20 15:44 ` Arnout Vandecappelle (Essensium/Mind)
2012-09-28 3:35 ` Artem Bityutskiy [this message]
2012-09-28 3:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348803345.1830.2.camel@kyv \
--to=dedekind1@gmail.com \
--cc=arnout@mind.be \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sven.krauss@web.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.