* [PATCH] jffs2: print symbolic error name instead of error code
@ 2024-02-11 0:39 ` Christian Heusel
0 siblings, 0 replies; 8+ messages in thread
From: Christian Heusel @ 2024-02-11 0:39 UTC (permalink / raw)
To: David Woodhouse, Richard Weinberger, Christian Heusel, linux-mtd,
linux-kernel
Cc: kernel-janitors
Utilize the %pe print specifier to get the symbolic error name as a
string (i.e "-ENOMEM") in the log message instead of the error code to
increase its readablility.
This change was suggested in
https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
Signed-off-by: Christian Heusel <christian@heusel.eu>
---
fs/jffs2/background.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
index 6da92ecaf66d..bb0ee1a59e71 100644
--- a/fs/jffs2/background.c
+++ b/fs/jffs2/background.c
@@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
if (IS_ERR(tsk)) {
- pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
- -PTR_ERR(tsk));
+ pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
+ tsk);
complete(&c->gc_thread_exit);
ret = PTR_ERR(tsk);
} else {
--
2.43.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] jffs2: print symbolic error name instead of error code
@ 2024-02-11 0:39 ` Christian Heusel
0 siblings, 0 replies; 8+ messages in thread
From: Christian Heusel @ 2024-02-11 0:39 UTC (permalink / raw)
To: David Woodhouse, Richard Weinberger, Christian Heusel, linux-mtd,
linux-kernel
Cc: kernel-janitors
Utilize the %pe print specifier to get the symbolic error name as a
string (i.e "-ENOMEM") in the log message instead of the error code to
increase its readablility.
This change was suggested in
https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
Signed-off-by: Christian Heusel <christian@heusel.eu>
---
fs/jffs2/background.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
index 6da92ecaf66d..bb0ee1a59e71 100644
--- a/fs/jffs2/background.c
+++ b/fs/jffs2/background.c
@@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
if (IS_ERR(tsk)) {
- pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
- -PTR_ERR(tsk));
+ pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
+ tsk);
complete(&c->gc_thread_exit);
ret = PTR_ERR(tsk);
} else {
--
2.43.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] jffs2: print symbolic error name instead of error code
2024-02-11 0:39 ` Christian Heusel
@ 2024-02-18 1:13 ` Zhihao Cheng
-1 siblings, 0 replies; 8+ messages in thread
From: Zhihao Cheng @ 2024-02-18 1:13 UTC (permalink / raw)
To: Christian Heusel, David Woodhouse, Richard Weinberger, linux-mtd,
linux-kernel
Cc: kernel-janitors
在 2024/2/11 8:39, Christian Heusel 写道:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> .
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] jffs2: print symbolic error name instead of error code
@ 2024-02-18 1:13 ` Zhihao Cheng
0 siblings, 0 replies; 8+ messages in thread
From: Zhihao Cheng @ 2024-02-18 1:13 UTC (permalink / raw)
To: Christian Heusel, David Woodhouse, Richard Weinberger, linux-mtd,
linux-kernel
Cc: kernel-janitors
在 2024/2/11 8:39, Christian Heusel 写道:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> .
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] jffs2: print symbolic error name instead of error code
2024-02-11 0:39 ` Christian Heusel
@ 2024-03-11 12:47 ` Christian Heusel
-1 siblings, 0 replies; 8+ messages in thread
From: Christian Heusel @ 2024-03-11 12:47 UTC (permalink / raw)
To: David Woodhouse, Richard Weinberger, linux-mtd, linux-kernel
Cc: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
On 24/02/11 01:39AM, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1
Friendly ping on the above patch, since it's now a month after sending
it :)
Cheers,
chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] jffs2: print symbolic error name instead of error code
@ 2024-03-11 12:47 ` Christian Heusel
0 siblings, 0 replies; 8+ messages in thread
From: Christian Heusel @ 2024-03-11 12:47 UTC (permalink / raw)
To: David Woodhouse, Richard Weinberger, linux-mtd, linux-kernel
Cc: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]
On 24/02/11 01:39AM, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1
Friendly ping on the above patch, since it's now a month after sending
it :)
Cheers,
chris
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] jffs2: print symbolic error name instead of error code
2024-03-11 12:47 ` Christian Heusel
@ 2024-03-11 12:56 ` Richard Weinberger
-1 siblings, 0 replies; 8+ messages in thread
From: Richard Weinberger @ 2024-03-11 12:56 UTC (permalink / raw)
To: Christian Heusel
Cc: David Woodhouse, linux-mtd, linux-kernel, kernel-janitors
----- Ursprüngliche Mail -----
> Von: "Christian Heusel" <christian@heusel.eu>
> An: "David Woodhouse" <dwmw2@infradead.org>, "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> "linux-kernel" <linux-kernel@vger.kernel.org>
> CC: "kernel-janitors" <kernel-janitors@vger.kernel.org>
> Gesendet: Montag, 11. März 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error code
> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>>
>> This change was suggested in
>> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>>
>> Signed-off-by: Christian Heusel <christian@heusel.eu>
>> ---
>> fs/jffs2/background.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info
>> *c)
>>
>> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",
>> c->mtd->index);
>> if (IS_ERR(tsk)) {
>> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> - -PTR_ERR(tsk));
>> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> + tsk);
>> complete(&c->gc_thread_exit);
>> ret = PTR_ERR(tsk);
>> } else {
>> --
>> 2.43.1
>
> Friendly ping on the above patch, since it's now a month after sending
> it :)
Thanks for the ping. Your patch looks good. I'll queue it.
Thanks,
//richard
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] jffs2: print symbolic error name instead of error code
@ 2024-03-11 12:56 ` Richard Weinberger
0 siblings, 0 replies; 8+ messages in thread
From: Richard Weinberger @ 2024-03-11 12:56 UTC (permalink / raw)
To: Christian Heusel
Cc: David Woodhouse, linux-mtd, linux-kernel, kernel-janitors
----- Ursprüngliche Mail -----
> Von: "Christian Heusel" <christian@heusel.eu>
> An: "David Woodhouse" <dwmw2@infradead.org>, "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> "linux-kernel" <linux-kernel@vger.kernel.org>
> CC: "kernel-janitors" <kernel-janitors@vger.kernel.org>
> Gesendet: Montag, 11. März 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error code
> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>>
>> This change was suggested in
>> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>>
>> Signed-off-by: Christian Heusel <christian@heusel.eu>
>> ---
>> fs/jffs2/background.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info
>> *c)
>>
>> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",
>> c->mtd->index);
>> if (IS_ERR(tsk)) {
>> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> - -PTR_ERR(tsk));
>> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> + tsk);
>> complete(&c->gc_thread_exit);
>> ret = PTR_ERR(tsk);
>> } else {
>> --
>> 2.43.1
>
> Friendly ping on the above patch, since it's now a month after sending
> it :)
Thanks for the ping. Your patch looks good. I'll queue it.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-03-11 12:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-11 0:39 [PATCH] jffs2: print symbolic error name instead of error code Christian Heusel
2024-02-11 0:39 ` Christian Heusel
2024-02-18 1:13 ` Zhihao Cheng
2024-02-18 1:13 ` Zhihao Cheng
2024-03-11 12:47 ` Christian Heusel
2024-03-11 12:47 ` Christian Heusel
2024-03-11 12:56 ` Richard Weinberger
2024-03-11 12:56 ` Richard Weinberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.