From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Chandrabhanu Mahapatra <cmahapatra@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V4 4/5] OMAPDSS: Replace multi part debug prints with pr_debug
Date: Fri, 05 Oct 2012 12:33:53 +0000 [thread overview]
Message-ID: <1349440433.5836.0.camel@deskari> (raw)
In-Reply-To: <8fb0b3848f5d6148889f2b5160b8aa40e764f409.1348914940.git.cmahapatra@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
On Sat, 2012-09-29 at 16:19 +0530, Chandrabhanu Mahapatra wrote:
> The omap_dispc_unregister_isr() and _dsi_print_reset_status() consist of a
> number of debug prints which need to be enabled all at once or none at all. So,
> these debug prints in corresponding functions are replaced with one dynamic
> debug enabled pr_debug() each.
>
> Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> ---
> drivers/video/omap2/dss/dispc.c | 32 +++++++++++++-------------------
> drivers/video/omap2/dss/dsi.c | 30 ++++++++++++++----------------
> 2 files changed, 27 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
> index a173a94..67d9f3b 100644
> --- a/drivers/video/omap2/dss/dispc.c
> +++ b/drivers/video/omap2/dss/dispc.c
> @@ -3675,26 +3675,20 @@ static void print_irq_status(u32 status)
> if ((status & dispc.irq_error_mask) == 0)
> return;
>
> - printk(KERN_DEBUG "DISPC IRQ: 0x%x: ", status);
> -
> -#define PIS(x) \
> - if (status & DISPC_IRQ_##x) \
> - printk(#x " ");
> - PIS(GFX_FIFO_UNDERFLOW);
> - PIS(OCP_ERR);
> - PIS(VID1_FIFO_UNDERFLOW);
> - PIS(VID2_FIFO_UNDERFLOW);
> - if (dss_feat_get_num_ovls() > 3)
> - PIS(VID3_FIFO_UNDERFLOW);
> - PIS(SYNC_LOST);
> - PIS(SYNC_LOST_DIGIT);
> - if (dss_has_feature(FEAT_MGR_LCD2))
> - PIS(SYNC_LOST2);
> - if (dss_has_feature(FEAT_MGR_LCD3))
> - PIS(SYNC_LOST3);
> +#define PIS(x) (status & DISPC_IRQ_##x) ? (#x " ") : ""
> +
> + pr_debug("DISPC IRQ: 0x%x: %s%s%s%s%s%s%s%s%s\n",
> + status,
> + PIS(OCP_ERR),
> + PIS(GFX_FIFO_UNDERFLOW),
> + PIS(VID1_FIFO_UNDERFLOW),
> + PIS(VID2_FIFO_UNDERFLOW),
> + dss_feat_get_num_ovls() > 3 ? PIS(VID3_FIFO_UNDERFLOW) : "",
> + PIS(SYNC_LOST),
> + PIS(SYNC_LOST_DIGIT),
> + dss_has_feature(FEAT_MGR_LCD2) ? PIS(SYNC_LOST2) : "",
> + dss_has_feature(FEAT_MGR_LCD3) ? PIS(SYNC_LOST3) : "");
> #undef PIS
> -
> - printk("\n");
> }
> #endif
There's similar irq printing code in dsi.c that should also be converted
to the above style.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Chandrabhanu Mahapatra <cmahapatra@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V4 4/5] OMAPDSS: Replace multi part debug prints with pr_debug
Date: Fri, 05 Oct 2012 15:33:53 +0300 [thread overview]
Message-ID: <1349440433.5836.0.camel@deskari> (raw)
In-Reply-To: <8fb0b3848f5d6148889f2b5160b8aa40e764f409.1348914940.git.cmahapatra@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
On Sat, 2012-09-29 at 16:19 +0530, Chandrabhanu Mahapatra wrote:
> The omap_dispc_unregister_isr() and _dsi_print_reset_status() consist of a
> number of debug prints which need to be enabled all at once or none at all. So,
> these debug prints in corresponding functions are replaced with one dynamic
> debug enabled pr_debug() each.
>
> Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> ---
> drivers/video/omap2/dss/dispc.c | 32 +++++++++++++-------------------
> drivers/video/omap2/dss/dsi.c | 30 ++++++++++++++----------------
> 2 files changed, 27 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
> index a173a94..67d9f3b 100644
> --- a/drivers/video/omap2/dss/dispc.c
> +++ b/drivers/video/omap2/dss/dispc.c
> @@ -3675,26 +3675,20 @@ static void print_irq_status(u32 status)
> if ((status & dispc.irq_error_mask) == 0)
> return;
>
> - printk(KERN_DEBUG "DISPC IRQ: 0x%x: ", status);
> -
> -#define PIS(x) \
> - if (status & DISPC_IRQ_##x) \
> - printk(#x " ");
> - PIS(GFX_FIFO_UNDERFLOW);
> - PIS(OCP_ERR);
> - PIS(VID1_FIFO_UNDERFLOW);
> - PIS(VID2_FIFO_UNDERFLOW);
> - if (dss_feat_get_num_ovls() > 3)
> - PIS(VID3_FIFO_UNDERFLOW);
> - PIS(SYNC_LOST);
> - PIS(SYNC_LOST_DIGIT);
> - if (dss_has_feature(FEAT_MGR_LCD2))
> - PIS(SYNC_LOST2);
> - if (dss_has_feature(FEAT_MGR_LCD3))
> - PIS(SYNC_LOST3);
> +#define PIS(x) (status & DISPC_IRQ_##x) ? (#x " ") : ""
> +
> + pr_debug("DISPC IRQ: 0x%x: %s%s%s%s%s%s%s%s%s\n",
> + status,
> + PIS(OCP_ERR),
> + PIS(GFX_FIFO_UNDERFLOW),
> + PIS(VID1_FIFO_UNDERFLOW),
> + PIS(VID2_FIFO_UNDERFLOW),
> + dss_feat_get_num_ovls() > 3 ? PIS(VID3_FIFO_UNDERFLOW) : "",
> + PIS(SYNC_LOST),
> + PIS(SYNC_LOST_DIGIT),
> + dss_has_feature(FEAT_MGR_LCD2) ? PIS(SYNC_LOST2) : "",
> + dss_has_feature(FEAT_MGR_LCD3) ? PIS(SYNC_LOST3) : "");
> #undef PIS
> -
> - printk("\n");
> }
> #endif
There's similar irq printing code in dsi.c that should also be converted
to the above style.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-05 12:33 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 6:03 [PATCH] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-25 6:15 ` Chandrabhanu Mahapatra
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 9:30 ` Mahapatra, Chandrabhanu
2012-09-25 9:42 ` Mahapatra, Chandrabhanu
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-26 5:15 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:15 ` [PATCH V2 1/2] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:16 ` [PATCH V2 2/2] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-26 5:28 ` Chandrabhanu Mahapatra
2012-09-26 14:29 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-26 14:29 ` Tomi Valkeinen
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 0/3] " Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 10:23 ` [PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 10:23 ` [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:30 ` Mahapatra, Chandrabhanu
2012-09-28 11:42 ` Mahapatra, Chandrabhanu
2012-09-28 11:37 ` Tomi Valkeinen
2012-09-28 11:37 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 3/3] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:34 ` [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-28 11:34 ` Tomi Valkeinen
2012-09-28 12:11 ` Mahapatra, Chandrabhanu
2012-09-28 12:23 ` Mahapatra, Chandrabhanu
2012-09-29 10:49 ` [PATCH V4 0/5] " Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 1/5] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 2/5] OMAPDSS: Create new debug config options Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 15:15 ` Sumit Semwal
2012-09-29 15:27 ` Sumit Semwal
2012-10-01 7:48 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-01 7:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 3/5] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 4/5] OMAPDSS: Replace multi part debug prints with pr_debug Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:33 ` Tomi Valkeinen [this message]
2012-10-05 12:33 ` Tomi Valkeinen
2012-10-10 9:22 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-10 9:34 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 5/5] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:46 ` [PATCH V4 0/5] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-10-05 12:46 ` Tomi Valkeinen
2012-10-10 10:26 ` Sumit Semwal
2012-10-10 10:38 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349440433.5836.0.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=cmahapatra@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.