From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Tirumala Marri <tmarri@apm.com>, Jim Johnston <jjohnston@apm.com>,
Richard Zenkert <rzenkert@apm.com>,
Scarlett Smith <slsmith@apm.com>
Subject: Re: [RFC PATCH] KVM: PPC: Remove 44x target
Date: Mon, 08 Oct 2012 20:50:03 +0000 [thread overview]
Message-ID: <1349729403.3721.7@snotra> (raw)
In-Reply-To: <1349618282-32227-1-git-send-email-agraf@suse.de> (from agraf@suse.de on Sun Oct 7 08:58:02 2012)
On 10/07/2012 08:58:02 AM, Alexander Graf wrote:
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S
> b/arch/powerpc/kvm/bookehv_interrupts.S
> index 099fe82..4421293 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -23,7 +23,6 @@
> #include <asm/ppc_asm.h>
> #include <asm/kvm_asm.h>
> #include <asm/reg.h>
> -#include <asm/mmu-44x.h>
> #include <asm/page.h>
> #include <asm/asm-compat.h>
> #include <asm/asm-offsets.h>
This could come out of here regardless of whether 44x stays.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 7d120dc..f522110 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -158,10 +158,7 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu)
> }
> case KVM_HCALL_TOKEN(KVM_HC_FEATURES):
> r = EV_SUCCESS;
> -#if defined(CONFIG_PPC_BOOK3S) || defined(CONFIG_KVM_E500V2)
> - /* XXX Missing magic page on 44x */
> r2 |= (1 << KVM_FEATURE_MAGIC_PAGE);
> -#endif
We also don't support this on e500mc -- or at least it hasn't been
tested, and would be pretty pointless nothing in the magic page traps
on e500mc.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>,
Tirumala Marri <tmarri@apm.com>, Jim Johnston <jjohnston@apm.com>,
Richard Zenkert <rzenkert@apm.com>,
Scarlett Smith <slsmith@apm.com>
Subject: Re: [RFC PATCH] KVM: PPC: Remove 44x target
Date: Mon, 8 Oct 2012 15:50:03 -0500 [thread overview]
Message-ID: <1349729403.3721.7@snotra> (raw)
In-Reply-To: <1349618282-32227-1-git-send-email-agraf@suse.de> (from agraf@suse.de on Sun Oct 7 08:58:02 2012)
On 10/07/2012 08:58:02 AM, Alexander Graf wrote:
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S
> b/arch/powerpc/kvm/bookehv_interrupts.S
> index 099fe82..4421293 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -23,7 +23,6 @@
> #include <asm/ppc_asm.h>
> #include <asm/kvm_asm.h>
> #include <asm/reg.h>
> -#include <asm/mmu-44x.h>
> #include <asm/page.h>
> #include <asm/asm-compat.h>
> #include <asm/asm-offsets.h>
This could come out of here regardless of whether 44x stays.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 7d120dc..f522110 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -158,10 +158,7 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu)
> }
> case KVM_HCALL_TOKEN(KVM_HC_FEATURES):
> r = EV_SUCCESS;
> -#if defined(CONFIG_PPC_BOOK3S) || defined(CONFIG_KVM_E500V2)
> - /* XXX Missing magic page on 44x */
> r2 |= (1 << KVM_FEATURE_MAGIC_PAGE);
> -#endif
We also don't support this on e500mc -- or at least it hasn't been
tested, and would be pretty pointless nothing in the magic page traps
on e500mc.
-Scott
next prev parent reply other threads:[~2012-10-08 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 13:58 [RFC PATCH] KVM: PPC: Remove 44x target Alexander Graf
2012-10-07 13:58 ` Alexander Graf
2012-10-08 20:50 ` Scott Wood [this message]
2012-10-08 20:50 ` Scott Wood
2012-10-08 20:52 ` Alexander Graf
2012-10-08 20:52 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349729403.3721.7@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=jjohnston@apm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=rzenkert@apm.com \
--cc=slsmith@apm.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.