From: Johannes Berg <johannes@sipsolutions.net>
To: Marco Porsch <marco.porsch@etit.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: make powersave independent of interface type
Date: Wed, 10 Oct 2012 07:30:23 +0200 [thread overview]
Message-ID: <1349847023.4683.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <5074886E.1040400@etit.tu-chemnitz.de>
On Tue, 2012-10-09 at 13:26 -0700, Marco Porsch wrote:
> On 10/09/2012 11:39 AM, Johannes Berg wrote:
> >> Does it make any sense to test for NL80211_IFTYPE_AP and
> >> NL80211_IFTYPE_AP_VLAN everytime?
> >
> > Not sure how you mean that?
> >
>
> See, I use the disjunction
> + if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
> + sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
> at least 5 times. I thought in some situations it may be only necessary
> to check for one of them, because of the function context.
I don't think so, but honestly, I haven't looked very closely :)
johannes
next prev parent reply other threads:[~2012-10-10 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 18:07 [RFC] mac80211: make powersave independent of interface type Marco Porsch
2012-10-09 18:39 ` Johannes Berg
2012-10-09 20:26 ` Marco Porsch
2012-10-10 5:30 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-02 6:46 broadcast buffer / TIM map in mesh mode Johannes Berg
2012-10-02 22:38 ` [RFC] mac80211: make powersave independent of interface type Marco Porsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349847023.4683.25.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marco.porsch@etit.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.