Re: [RFC] mac80211: make powersave independent of interface type

[Marco Porsch <marco.porsch@etit.tu-chemnitz.de>]

[-- Attachment #1.1: Type: text/plain, Size: 548 bytes --]

On 10/09/2012 11:39 AM, Johannes Berg wrote:
>> Does it make any sense to test for NL80211_IFTYPE_AP and
>> NL80211_IFTYPE_AP_VLAN everytime?
>
> Not sure how you mean that?
>

See, I use the disjunction
+ if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
+     sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
at least 5 times. I thought in some situations it may be only necessary 
to check for one of them, because of the function context.

> Looks good.

Thanks. Will polish it and send a patch when ready.

Regards,
Marco


[-- Attachment #1.2: marco_porsch.vcf --]
[-- Type: text/x-vcard, Size: 432 bytes --]

begin:vcard
fn:Marco Porsch
n:Porsch;Marco
org:Chemnitz University of Technology;Communication Networks
adr;quoted-printable;quoted-printable:Fakult=C3=A4t f=C3=BCr Elektrotechnik und Informationstechnik , Professur=
	 Kommunikationsnetze;;Technische Universit=C3=A4t Chemnitz;Chemnitz;;D - 09107;Germany
email;internet:marco.porsch@etit.tu-chemnitz.de
title:Dipl.-Ing.
tel;work:+49 371 531 37523
version:2.1
end:vcard


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5101 bytes --]