* [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
@ 2012-10-10 10:32 ` Constantine Shulyupin
0 siblings, 0 replies; 4+ messages in thread
From: Constantine Shulyupin @ 2012-10-10 10:32 UTC (permalink / raw)
To: linux-arm-kernel
From: Constantine Shulyupin <const@MakeLinux.com>
Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.
--
Changelog:
-- Fixed accordinly feedback of Oliver Neukum oneukum at suse.de: also need to drop the lock.
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
drivers/usb/usb-skeleton.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 0616f23..2025d03 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -113,8 +113,9 @@ static int skel_open(struct inode *inode, struct file *file)
mutex_lock(&dev->io_mutex);
retval = usb_autopm_get_interface(interface);
- if (retval)
- goto out_err;
+ if (retval) {
+ kref_put(&dev->kref, skel_delete);
+ }
/* save our object in the file's private structure */
file->private_data = dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
@ 2012-10-10 10:32 ` Constantine Shulyupin
0 siblings, 0 replies; 4+ messages in thread
From: Constantine Shulyupin @ 2012-10-10 10:32 UTC (permalink / raw)
To: nsekhar, gregkh, oneukum
Cc: Constantine Shulyupin, davinci-linux-open-source, linux-usb,
linux-kernel, balbi, linux-arm-kernel
From: Constantine Shulyupin <const@MakeLinux.com>
Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.
--
Changelog:
-- Fixed accordinly feedback of Oliver Neukum oneukum@suse.de: also need to drop the lock.
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
drivers/usb/usb-skeleton.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 0616f23..2025d03 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -113,8 +113,9 @@ static int skel_open(struct inode *inode, struct file *file)
mutex_lock(&dev->io_mutex);
retval = usb_autopm_get_interface(interface);
- if (retval)
- goto out_err;
+ if (retval) {
+ kref_put(&dev->kref, skel_delete);
+ }
/* save our object in the file's private structure */
file->private_data = dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
2012-10-10 10:32 ` Constantine Shulyupin
@ 2012-10-10 12:35 ` Oliver Neukum
-1 siblings, 0 replies; 4+ messages in thread
From: Oliver Neukum @ 2012-10-10 12:35 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote:
> From: Constantine Shulyupin <const@MakeLinux.com>
>
> Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
>
> Some last changes in function skel_open and finally commit
> 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
> introduced a bug in function skel_open, which this patch fixes.
>
> --
> Changelog:
> -- Fixed accordinly feedback of Oliver Neukum oneukum at suse.de: also need to drop the lock.
Well, touching file->private_data is not nice. It is correct, but
really dirty. The skeleton driver should be nice. Could you introduce
a second label for goto at the right place?
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
@ 2012-10-10 12:35 ` Oliver Neukum
0 siblings, 0 replies; 4+ messages in thread
From: Oliver Neukum @ 2012-10-10 12:35 UTC (permalink / raw)
To: Constantine Shulyupin
Cc: nsekhar, gregkh, davinci-linux-open-source, linux-usb,
linux-kernel, balbi, linux-arm-kernel
On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote:
> From: Constantine Shulyupin <const@MakeLinux.com>
>
> Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
>
> Some last changes in function skel_open and finally commit
> 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
> introduced a bug in function skel_open, which this patch fixes.
>
> --
> Changelog:
> -- Fixed accordinly feedback of Oliver Neukum oneukum@suse.de: also need to drop the lock.
Well, touching file->private_data is not nice. It is correct, but
really dirty. The skeleton driver should be nice. Could you introduce
a second label for goto at the right place?
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-10 12:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 10:32 [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open Constantine Shulyupin
2012-10-10 10:32 ` Constantine Shulyupin
2012-10-10 12:35 ` Oliver Neukum
2012-10-10 12:35 ` Oliver Neukum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.