Re: [Powertop] [PATCH] cpu: Fix abstract_cpu::calculate_freq

[Namhyung Kim <namhyung at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

2012-09-20 (목), 17:46 +0300, Sergey Senozhatsky:
> On (09/20/12 23:33), Namhyung Kim wrote:
> > The 'freq' should have the maximun frequency value of all children.
> > But the current code does not update the freq properly.  Fix it.
> > 
> > Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> 
> looks good to me, thanks.
> 
> 	-ss

Ping.  

It seems that it's not merged yet.  Chris, could you please merge this?

Thanks,
Namhyung

> 
> > ---
> >  src/cpu/abstract_cpu.cpp |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/cpu/abstract_cpu.cpp b/src/cpu/abstract_cpu.cpp
> > index 386d981..de55cf2 100644
> > --- a/src/cpu/abstract_cpu.cpp
> > +++ b/src/cpu/abstract_cpu.cpp
> > @@ -341,7 +341,7 @@ void abstract_cpu::calculate_freq(uint64_t time)
> >  				is_idle = false;
> >  			}
> >  			if (f > freq)
> > -				f = freq;
> > +				freq = f;
> >  		}
> >  
> >  	current_frequency = freq;


-- 
Regards,
Namhyung Kim