From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] cpu: Fix abstract_cpu::calculate_freq
Date: Mon, 15 Oct 2012 09:22:55 -0700 [thread overview]
Message-ID: <507C385F.3010806@linux.intel.com> (raw)
In-Reply-To: 1348151599-2740-1-git-send-email-namhyung@gmail.com
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On 09/20/2012 07:33 AM, Namhyung Kim wrote:
> The 'freq' should have the maximun frequency value of all children.
> But the current code does not update the freq properly. Fix it.
>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
> src/cpu/abstract_cpu.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/cpu/abstract_cpu.cpp b/src/cpu/abstract_cpu.cpp
> index 386d981..de55cf2 100644
> --- a/src/cpu/abstract_cpu.cpp
> +++ b/src/cpu/abstract_cpu.cpp
> @@ -341,7 +341,7 @@ void abstract_cpu::calculate_freq(uint64_t time)
> is_idle = false;
> }
> if (f > freq)
> - f = freq;
> + freq = f;
> }
>
> current_frequency = freq;
Your patch has been merged
Thank You
-C
next reply other threads:[~2012-10-15 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 16:22 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-15 14:22 [Powertop] [PATCH] cpu: Fix abstract_cpu::calculate_freq Namhyung Kim
2012-09-20 14:46 Sergey Senozhatsky
2012-09-20 14:33 Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C385F.3010806@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.