All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-commits@lists.openembedded.org,
	openembedded-devel@lists.openembedded.org,
	openembedded-core@lists.openembedded.org
Subject: Re: [oe-commits] Robert Yang : perl: fix dependecies
Date: Mon, 22 Oct 2012 11:49:09 +0100	[thread overview]
Message-ID: <1350902949.2520.72.camel@ted> (raw)
In-Reply-To: <20121022083441.GA3269@jama.jama.net>

On Mon, 2012-10-22 at 10:34 +0200, Martin Jansa wrote:
> >  # 5.10.1 has Module::Build built-in
> >  PROVIDES += "libmodule-build-perl"
> > @@ -243,7 +243,13 @@ perl_package_preprocess () {
> >  
> >  PACKAGES = "perl-dbg perl perl-misc perl-dev perl-pod perl-doc perl-lib \
> >              perl-module-cpan perl-module-cpanplus perl-module-unicore"
> > -FILES_${PN} = "${bindir}/perl ${bindir}/perl${PV}"
> > +FILES_${PN} = "${bindir}/perl ${bindir}/perl${PV} \
> > +               ${libdir}/perl/${PV}/Config.pm \
> > +               ${libdir}/perl/${PV}/strict.pm \
> > +               ${libdir}/perl/${PV}/warnings.pm \
> > +               ${libdir}/perl/${PV}/warnings \
> > +               ${libdir}/perl/${PV}/vars.pm \
> > +              "
> 
> I think this breaks at least automake, tiobench and libtimedate-perl
> 
> OE @ ~/openembedded-core $ git grep perl-module-strict
> meta/recipes-devtools/automake/automake_1.12.3.bb:    perl-module-strict \
> meta/recipes-extended/perl/libtimedate-perl_1.20.bb:RDEPENDS_${PN} += "perl-module-carp perl-module-exporter perl-module-strict perl-module-time-local"
> OE @ ~/meta-openembedded $ git grep perl-module-strict
> meta-oe/recipes-benchmark/tiobench/tiobench_0.3.3.bb:    perl-module-strict \
> OE @ ~/openembedded-core $ git grep perl-module-vars
> meta/recipes-devtools/automake/automake_1.12.3.bb:    perl-module-vars "
> 
> perl-module-strict and perl-module-vars are not created now, probably empty.
> 

It does, the autobuilder also noticed this and I pushed in a fix this
morning:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=072a6d352f55bbe481b04db02aa6d9cde7d90057

Cheers,

Richard




WARNING: multiple messages have this Message-ID (diff)
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-commits@lists.openembedded.org,
	openembedded-devel@lists.openembedded.org,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [oe-commits] Robert Yang : perl: fix dependecies
Date: Mon, 22 Oct 2012 11:49:09 +0100	[thread overview]
Message-ID: <1350902949.2520.72.camel@ted> (raw)
In-Reply-To: <20121022083441.GA3269@jama.jama.net>

On Mon, 2012-10-22 at 10:34 +0200, Martin Jansa wrote:
> >  # 5.10.1 has Module::Build built-in
> >  PROVIDES += "libmodule-build-perl"
> > @@ -243,7 +243,13 @@ perl_package_preprocess () {
> >  
> >  PACKAGES = "perl-dbg perl perl-misc perl-dev perl-pod perl-doc perl-lib \
> >              perl-module-cpan perl-module-cpanplus perl-module-unicore"
> > -FILES_${PN} = "${bindir}/perl ${bindir}/perl${PV}"
> > +FILES_${PN} = "${bindir}/perl ${bindir}/perl${PV} \
> > +               ${libdir}/perl/${PV}/Config.pm \
> > +               ${libdir}/perl/${PV}/strict.pm \
> > +               ${libdir}/perl/${PV}/warnings.pm \
> > +               ${libdir}/perl/${PV}/warnings \
> > +               ${libdir}/perl/${PV}/vars.pm \
> > +              "
> 
> I think this breaks at least automake, tiobench and libtimedate-perl
> 
> OE @ ~/openembedded-core $ git grep perl-module-strict
> meta/recipes-devtools/automake/automake_1.12.3.bb:    perl-module-strict \
> meta/recipes-extended/perl/libtimedate-perl_1.20.bb:RDEPENDS_${PN} += "perl-module-carp perl-module-exporter perl-module-strict perl-module-time-local"
> OE @ ~/meta-openembedded $ git grep perl-module-strict
> meta-oe/recipes-benchmark/tiobench/tiobench_0.3.3.bb:    perl-module-strict \
> OE @ ~/openembedded-core $ git grep perl-module-vars
> meta/recipes-devtools/automake/automake_1.12.3.bb:    perl-module-vars "
> 
> perl-module-strict and perl-module-vars are not created now, probably empty.
> 

It does, the autobuilder also noticed this and I pushed in a fix this
morning:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=072a6d352f55bbe481b04db02aa6d9cde7d90057

Cheers,

Richard




  reply	other threads:[~2012-10-22 11:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20121019163541.436A0103AB@opal>
2012-10-22  8:34 ` [oe-commits] Robert Yang : perl: fix dependecies Martin Jansa
2012-10-22 10:49   ` Richard Purdie [this message]
2012-10-22 10:49     ` [OE-core] " Richard Purdie
2012-10-22 11:01     ` Martin Jansa
2012-10-22 11:01       ` [OE-core] " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350902949.2520.72.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.