* [PATCH] DRM/Radeon: Fix Load Detection on legacy primary DAC.
@ 2012-10-24 16:29 Egbert Eich
2012-10-24 16:56 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Egbert Eich @ 2012-10-24 16:29 UTC (permalink / raw)
To: dri-devel; +Cc: Egbert Eich
An uninitialized variable led to broken load detection.
Signed-off-by: Egbert Eich <eich@suse.de>
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index 2630e4e..752e98b 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -668,6 +668,7 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
tmp |= RADEON_DAC_RANGE_CNTL_PS2 | RADEON_DAC_CMP_EN;
WREG32(RADEON_DAC_CNTL, tmp);
+ tmp = dac_macro_cntl;
tmp &= ~(RADEON_DAC_PDWN_R |
RADEON_DAC_PDWN_G |
RADEON_DAC_PDWN_B);
--
1.7.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DRM/Radeon: Fix Load Detection on legacy primary DAC.
2012-10-24 16:29 [PATCH] DRM/Radeon: Fix Load Detection on legacy primary DAC Egbert Eich
@ 2012-10-24 16:56 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2012-10-24 16:56 UTC (permalink / raw)
To: Egbert Eich; +Cc: dri-devel
On Wed, Oct 24, 2012 at 12:29 PM, Egbert Eich <eich@suse.de> wrote:
> An uninitialized variable led to broken load detection.
Looks good. Added to by -fixes queue.
Thanks!
Alex
>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 2630e4e..752e98b 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -668,6 +668,7 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
> tmp |= RADEON_DAC_RANGE_CNTL_PS2 | RADEON_DAC_CMP_EN;
> WREG32(RADEON_DAC_CNTL, tmp);
>
> + tmp = dac_macro_cntl;
> tmp &= ~(RADEON_DAC_PDWN_R |
> RADEON_DAC_PDWN_G |
> RADEON_DAC_PDWN_B);
> --
> 1.7.6.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-24 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 16:29 [PATCH] DRM/Radeon: Fix Load Detection on legacy primary DAC Egbert Eich
2012-10-24 16:56 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.