* [PATCH] bitbake: hob/builder: Hob crashes because of bad init
@ 2012-10-25 15:37 Cristian Iorga
2012-10-27 8:56 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Cristian Iorga @ 2012-10-25 15:37 UTC (permalink / raw)
To: bitbake-devel
Image selection is not properly initialized to none,
and it used before having a chance to have a value.
Due to dynamic nature of Python, variable is used before
it exists, in this case. This causes a crash.
Bug introduced during the fix of [YOCTO #3228]
Fixes [YOCTO #3334]
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
bitbake/lib/bb/ui/crumbs/builder.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
index 2fc4a29..3c3d303 100755
--- a/bitbake/lib/bb/ui/crumbs/builder.py
+++ b/bitbake/lib/bb/ui/crumbs/builder.py
@@ -89,6 +89,7 @@ class Configuration:
def __init__(self):
self.curr_mach = ""
+ self.selected_image = None
# settings
self.curr_distro = ""
self.dldir = self.sstatedir = self.sstatemirror = ""
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bitbake: hob/builder: Hob crashes because of bad init
2012-10-25 15:37 [PATCH] bitbake: hob/builder: Hob crashes because of bad init Cristian Iorga
@ 2012-10-27 8:56 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-10-27 8:56 UTC (permalink / raw)
To: Cristian Iorga; +Cc: bitbake-devel
On Thu, 2012-10-25 at 18:37 +0300, Cristian Iorga wrote:
> Image selection is not properly initialized to none,
> and it used before having a chance to have a value.
> Due to dynamic nature of Python, variable is used before
> it exists, in this case. This causes a crash.
> Bug introduced during the fix of [YOCTO #3228]
>
> Fixes [YOCTO #3334]
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> bitbake/lib/bb/ui/crumbs/builder.py | 1 +
> 1 file changed, 1 insertion(+)
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-27 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 15:37 [PATCH] bitbake: hob/builder: Hob crashes because of bad init Cristian Iorga
2012-10-27 8:56 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.