From: Ashish Jangam <ashish.jangam@kpitcummins.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Axel Lin <axel.lin@ingics.com>, Jean Delvare <khali@linux-fr.org>,
David Dajun Chen <dchen@diasemi.com>, <lm-sensors@lm-sensors.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting
Date: Tue, 30 Oct 2012 09:51:40 +0530 [thread overview]
Message-ID: <1351570900.19193.3.camel@dhruva> (raw)
In-Reply-To: <20121030005246.GB19374@roeck-us.net>
On Mon, 2012-10-29 at 17:52 -0700, Guenter Roeck wrote:
> On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote:
> > Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > Hi,
> > This looks like a typo, but I don't have a hardware to test it.
> > Axel
> > drivers/hwmon/da9055-hwmon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> > index 0b41f2c..3a3377c 100644
> > --- a/drivers/hwmon/da9055-hwmon.c
> > +++ b/drivers/hwmon/da9055-hwmon.c
> > @@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
> > [DA9055_ADC_VSYS] = DA9055_ADC_MUX_VSYS,
> > [DA9055_ADC_ADCIN1] = DA9055_ADC_MUX_ADCIN1,
> > [DA9055_ADC_ADCIN2] = DA9055_ADC_MUX_ADCIN2,
> > - [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN1,
> > + [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3,
> > [DA9055_ADC_TJUNC] = DA9055_ADC_MUX_T_SENSE,
> > };
>
> Very much loks like a typo.
>
> David, Ashish, any comments ? I would like to get your Ack before applying it.
>
> Thanks,
> Guenter
>
Yes, its typo so you can apply the patch.
next prev parent reply other threads:[~2012-10-30 4:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 8:34 [lm-sensors] [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting Axel Lin
2012-10-29 8:34 ` Axel Lin
2012-10-30 0:52 ` Guenter Roeck
2012-10-30 4:21 ` Ashish Jangam [this message]
2012-10-30 5:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351570900.19193.3.camel@dhruva \
--to=ashish.jangam@kpitcummins.com \
--cc=axel.lin@ingics.com \
--cc=dchen@diasemi.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.