* [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting
@ 2012-10-29 8:34 ` Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2012-10-29 8:34 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck
Cc: David Dajun Chen, Ashish Jangam, lm-sensors, linux-kernel
Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
This looks like a typo, but I don't have a hardware to test it.
Axel
drivers/hwmon/da9055-hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
index 0b41f2c..3a3377c 100644
--- a/drivers/hwmon/da9055-hwmon.c
+++ b/drivers/hwmon/da9055-hwmon.c
@@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
[DA9055_ADC_VSYS] = DA9055_ADC_MUX_VSYS,
[DA9055_ADC_ADCIN1] = DA9055_ADC_MUX_ADCIN1,
[DA9055_ADC_ADCIN2] = DA9055_ADC_MUX_ADCIN2,
- [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN1,
+ [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3,
[DA9055_ADC_TJUNC] = DA9055_ADC_MUX_T_SENSE,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting
2012-10-29 8:34 ` Axel Lin
(?)
@ 2012-10-30 0:52 ` Guenter Roeck
2012-10-30 4:21 ` Ashish Jangam
-1 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2012-10-30 0:52 UTC (permalink / raw)
To: Axel Lin
Cc: Jean Delvare, David Dajun Chen, Ashish Jangam, lm-sensors,
linux-kernel
On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote:
> Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> This looks like a typo, but I don't have a hardware to test it.
> Axel
> drivers/hwmon/da9055-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> index 0b41f2c..3a3377c 100644
> --- a/drivers/hwmon/da9055-hwmon.c
> +++ b/drivers/hwmon/da9055-hwmon.c
> @@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
> [DA9055_ADC_VSYS] = DA9055_ADC_MUX_VSYS,
> [DA9055_ADC_ADCIN1] = DA9055_ADC_MUX_ADCIN1,
> [DA9055_ADC_ADCIN2] = DA9055_ADC_MUX_ADCIN2,
> - [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN1,
> + [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3,
> [DA9055_ADC_TJUNC] = DA9055_ADC_MUX_T_SENSE,
> };
Very much loks like a typo.
David, Ashish, any comments ? I would like to get your Ack before applying it.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting
2012-10-30 0:52 ` Guenter Roeck
@ 2012-10-30 4:21 ` Ashish Jangam
0 siblings, 0 replies; 5+ messages in thread
From: Ashish Jangam @ 2012-10-30 4:21 UTC (permalink / raw)
To: Guenter Roeck
Cc: Axel Lin, Jean Delvare, David Dajun Chen, lm-sensors,
linux-kernel
On Mon, 2012-10-29 at 17:52 -0700, Guenter Roeck wrote:
> On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote:
> > Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > Hi,
> > This looks like a typo, but I don't have a hardware to test it.
> > Axel
> > drivers/hwmon/da9055-hwmon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> > index 0b41f2c..3a3377c 100644
> > --- a/drivers/hwmon/da9055-hwmon.c
> > +++ b/drivers/hwmon/da9055-hwmon.c
> > @@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
> > [DA9055_ADC_VSYS] = DA9055_ADC_MUX_VSYS,
> > [DA9055_ADC_ADCIN1] = DA9055_ADC_MUX_ADCIN1,
> > [DA9055_ADC_ADCIN2] = DA9055_ADC_MUX_ADCIN2,
> > - [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN1,
> > + [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3,
> > [DA9055_ADC_TJUNC] = DA9055_ADC_MUX_T_SENSE,
> > };
>
> Very much loks like a typo.
>
> David, Ashish, any comments ? I would like to get your Ack before applying it.
>
> Thanks,
> Guenter
>
Yes, its typo so you can apply the patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting
2012-10-29 8:34 ` Axel Lin
(?)
(?)
@ 2012-10-30 5:50 ` Guenter Roeck
-1 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2012-10-30 5:50 UTC (permalink / raw)
To: Axel Lin
Cc: Jean Delvare, David Dajun Chen, Ashish Jangam, lm-sensors,
linux-kernel
On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote:
> Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> This looks like a typo, but I don't have a hardware to test it.
> Axel
> drivers/hwmon/da9055-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> index 0b41f2c..3a3377c 100644
> --- a/drivers/hwmon/da9055-hwmon.c
> +++ b/drivers/hwmon/da9055-hwmon.c
> @@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
> [DA9055_ADC_VSYS] = DA9055_ADC_MUX_VSYS,
> [DA9055_ADC_ADCIN1] = DA9055_ADC_MUX_ADCIN1,
> [DA9055_ADC_ADCIN2] = DA9055_ADC_MUX_ADCIN2,
> - [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN1,
> + [DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3,
> [DA9055_ADC_TJUNC] = DA9055_ADC_MUX_T_SENSE,
> };
>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread