All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table
@ 2012-11-01 14:16 Axel Lin
  2012-11-02  4:18 ` Stephen Warren
  0 siblings, 1 reply; 4+ messages in thread
From: Axel Lin @ 2012-11-01 14:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Stephen Warren, Simon Arlott, Olof Johansson, linux-rpi-kernel,
	Arnd Bergmann

The of_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/irqchip/irq-bcm2835.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c
index dc670cc..16c78f1 100644
--- a/drivers/irqchip/irq-bcm2835.c
+++ b/drivers/irqchip/irq-bcm2835.c
@@ -168,7 +168,8 @@ static int __init armctrl_of_init(struct device_node *node,
 }
 
 static struct of_device_id irq_of_match[] __initconst = {
-	{ .compatible = "brcm,bcm2835-armctrl-ic", .data = armctrl_of_init }
+	{ .compatible = "brcm,bcm2835-armctrl-ic", .data = armctrl_of_init },
+	{ }
 };
 
 void __init bcm2835_init_irq(void)
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table
@ 2012-11-02  4:02 Stephen Warren
  2012-11-06 15:37 ` Olof Johansson
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2012-11-02  4:02 UTC (permalink / raw)
  To: linux-arm-kernel

From: Axel Lin <axel.lin@ingics.com>

The of_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
This is a fix for v3.7.

 drivers/irqchip/irq-bcm2835.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c
index dc670cc..16c78f1 100644
--- a/drivers/irqchip/irq-bcm2835.c
+++ b/drivers/irqchip/irq-bcm2835.c
@@ -168,7 +168,8 @@ static int __init armctrl_of_init(struct device_node *node,
 }
 
 static struct of_device_id irq_of_match[] __initconst = {
-	{ .compatible = "brcm,bcm2835-armctrl-ic", .data = armctrl_of_init }
+	{ .compatible = "brcm,bcm2835-armctrl-ic", .data = armctrl_of_init },
+	{ }
 };
 
 void __init bcm2835_init_irq(void)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table
  2012-11-01 14:16 [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table Axel Lin
@ 2012-11-02  4:18 ` Stephen Warren
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2012-11-02  4:18 UTC (permalink / raw)
  To: Axel Lin
  Cc: linux-kernel, Simon Arlott, Olof Johansson, linux-rpi-kernel,
	Arnd Bergmann

On 11/01/2012 08:16 AM, Axel Lin wrote:
> The of_device_id table is supposed to be zero-terminated.

Thanks. How embarrassing! I forwarded this to arm-soc for inclusion into
3.7.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table
  2012-11-02  4:02 Stephen Warren
@ 2012-11-06 15:37 ` Olof Johansson
  0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2012-11-06 15:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Nov 01, 2012 at 10:02:50PM -0600, Stephen Warren wrote:
> From: Axel Lin <axel.lin@ingics.com>
> 
> The of_device_id table is supposed to be zero-terminated.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> This is a fix for v3.7.

Thanks, applied.


-Olof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-11-06 15:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01 14:16 [PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table Axel Lin
2012-11-02  4:18 ` Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2012-11-02  4:02 Stephen Warren
2012-11-06 15:37 ` Olof Johansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.