* [PATCH] pinctrl: spear: Staticize non-exported symbols
@ 2012-11-11 2:29 Axel Lin
2012-11-11 2:44 ` viresh kumar
2012-11-13 14:05 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-11-11 2:29 UTC (permalink / raw)
To: Linus Walleij; +Cc: Viresh Kumar, linux-kernel
They are not referenced outside of this file, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/spear/pinctrl-spear.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
index b1fd6ee..9a4dd4e 100644
--- a/drivers/pinctrl/spear/pinctrl-spear.c
+++ b/drivers/pinctrl/spear/pinctrl-spear.c
@@ -121,9 +121,10 @@ static void spear_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
seq_printf(s, " " DRIVER_NAME);
}
-int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
- struct device_node *np_config,
- struct pinctrl_map **map, unsigned *num_maps)
+static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
+ struct device_node *np_config,
+ struct pinctrl_map **map,
+ unsigned *num_maps)
{
struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
struct device_node *np;
@@ -168,8 +169,9 @@ int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
return 0;
}
-void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
- struct pinctrl_map *map, unsigned num_maps)
+static void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
+ struct pinctrl_map *map,
+ unsigned num_maps)
{
kfree(map);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: spear: Staticize non-exported symbols
2012-11-11 2:29 [PATCH] pinctrl: spear: Staticize non-exported symbols Axel Lin
@ 2012-11-11 2:44 ` viresh kumar
2012-11-13 14:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: viresh kumar @ 2012-11-11 2:44 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, linux-kernel, spear-devel
On Sun, Nov 11, 2012 at 7:59 AM, Axel Lin <axel.lin@ingics.com> wrote:
> They are not referenced outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/spear/pinctrl-spear.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
> index b1fd6ee..9a4dd4e 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear.c
> @@ -121,9 +121,10 @@ static void spear_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
> seq_printf(s, " " DRIVER_NAME);
> }
>
> -int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> - struct device_node *np_config,
> - struct pinctrl_map **map, unsigned *num_maps)
> +static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> + struct device_node *np_config,
> + struct pinctrl_map **map,
> + unsigned *num_maps)
> {
> struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
> struct device_node *np;
> @@ -168,8 +169,9 @@ int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> return 0;
> }
>
> -void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
> - struct pinctrl_map *map, unsigned num_maps)
> +static void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
> + struct pinctrl_map *map,
> + unsigned num_maps)
> {
> kfree(map);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: spear: Staticize non-exported symbols
2012-11-11 2:29 [PATCH] pinctrl: spear: Staticize non-exported symbols Axel Lin
2012-11-11 2:44 ` viresh kumar
@ 2012-11-13 14:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-11-13 14:05 UTC (permalink / raw)
To: Axel Lin; +Cc: Viresh Kumar, linux-kernel
On Sun, Nov 11, 2012 at 3:29 AM, Axel Lin <axel.lin@ingics.com> wrote:
> They are not referenced outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied with Viresh's ACK.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-13 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-11 2:29 [PATCH] pinctrl: spear: Staticize non-exported symbols Axel Lin
2012-11-11 2:44 ` viresh kumar
2012-11-13 14:05 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.