From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: clean up locking in inet_frag_find()
Date: Mon, 26 Nov 2012 13:53:04 +0800 [thread overview]
Message-ID: <1353909184.11282.3.camel@cr0> (raw)
In-Reply-To: <1353908592.30446.1136.camel@edumazet-glaptop>
On Sun, 2012-11-25 at 21:43 -0800, Eric Dumazet wrote:
> On Mon, 2012-11-26 at 13:18 +0800, Cong Wang wrote:
> > It is weird to take the read lock outside of inet_frag_find()
> > but release it inside... Also, the hash function doesn't
> > need this lock.
>
> This patch is wrong. hash needs the lock.
>
>
Indeed, I missed .rnd...
I am cooking a better patch now.
Thanks!
next prev parent reply other threads:[~2012-11-26 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 5:18 [PATCH net-next] net: clean up locking in inet_frag_find() Cong Wang
2012-11-26 5:43 ` Eric Dumazet
2012-11-26 5:53 ` Cong Wang [this message]
2012-11-26 7:26 ` [PATCH net-next v2] " Cong Wang
2012-11-26 13:42 ` Jesper Dangaard Brouer
2012-11-26 15:12 ` Eric Dumazet
2012-11-27 3:05 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353909184.11282.3.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.