From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Cong Wang <amwang@redhat.com>, David Miller <davem@redhat.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v2] net: clean up locking in inet_frag_find()
Date: Mon, 26 Nov 2012 14:42:31 +0100 [thread overview]
Message-ID: <1353937351.11754.207.camel@localhost> (raw)
In-Reply-To: <1353914786-10426-1-git-send-email-amwang@redhat.com>
Could we please hold back on this cleanup patch, as I have a stack of 9
patches modifying this area.
If people find this cleanup useful/correct?, I can integrate it into my
patch stack...
--Jesper
On Mon, 2012-11-26 at 15:26 +0800, Cong Wang wrote:
> It is weird to take the read lock outside of inet_frag_find()
> but release it inside... This can be improved by refactoring
> the code, that is, introducing inet{4,6}_frag_find() which call
> the their own hash function, inet{4,6}_hash_frag(), hiding the
> details from their callers.
next prev parent reply other threads:[~2012-11-26 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 5:18 [PATCH net-next] net: clean up locking in inet_frag_find() Cong Wang
2012-11-26 5:43 ` Eric Dumazet
2012-11-26 5:53 ` Cong Wang
2012-11-26 7:26 ` [PATCH net-next v2] " Cong Wang
2012-11-26 13:42 ` Jesper Dangaard Brouer [this message]
2012-11-26 15:12 ` Eric Dumazet
2012-11-27 3:05 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353937351.11754.207.camel@localhost \
--to=jbrouer@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.